You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/02 19:19:04 UTC
[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some
problems around the default constructor detection
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651093#comment-14651093 ]
ASF GitHub Bot commented on FLINK-2437:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/960#issuecomment-127046830
Why are you changing all messages in this pull request? They were not wrong before...
> TypeExtractor.analyzePojo has some problems around the default constructor detection
> ------------------------------------------------------------------------------------
>
> Key: FLINK-2437
> URL: https://issues.apache.org/jira/browse/FLINK-2437
> Project: Flink
> Issue Type: Bug
> Components: Type Serialization System
> Reporter: Gabor Gevay
> Assignee: Gabor Gevay
> Priority: Minor
>
> If a class does have a default constructor, but the user forgot to make it public, then TypeExtractor.analyzePojo still thinks everything is OK, so it creates a PojoTypeInfo. Then PojoSerializer.createInstance blows up.
> Furthermore, a "return null" seems to be missing from the then case of the if after catching the NoSuchMethodException which would also cause a headache for PojoSerializer.
> An additional minor issue is that the word "class" is printed twice in several places, because class.toString also prepends it to the class name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)