You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ma...@apache.org on 2002/02/04 14:57:40 UTC
cvs commit: apache-1.3/src Configure CHANGES
martin 02/02/04 05:57:40
Modified: . configure
src Configure CHANGES
Log:
Fix the longstanding bug that errors (returned by src/Configure)
would not be noticed by the top level configure script.
That was bad for automated production environments, as errors would
go thru unnoticed, and caused havoc much later in the production.
Reviewed by: Jim Jagielski
Revision Changes Path
1.134 +5 -4 apache-1.3/configure
Index: configure
===================================================================
RCS file: /home/cvs/apache-1.3/configure,v
retrieving revision 1.133
retrieving revision 1.134
diff -u -r1.133 -r1.134
--- configure 27 Sep 2001 18:12:03 -0000 1.133
+++ configure 4 Feb 2002 13:57:39 -0000 1.134
@@ -1582,14 +1582,15 @@
if [ "x$verbose" = "xyes" ]; then
vflag="-v";
fi
-if [ "x$quiet" = "xyes" ]; then
- (cd $src; ./Configure ${vflag} -file Configuration.apaci >/dev/null);
+rc=`if [ "x$quiet" = "xyes" ]; then
+ (cd $src; ./Configure ${vflag} -file Configuration.apaci >/dev/null; echo $? >&3; );
else
- (cd $src; ./Configure ${vflag} -file Configuration.apaci |\
+ (cd $src; ( ./Configure ${vflag} -file Configuration.apaci; echo $? >&3; ) |\
sed -e '/^Using config file:.*/d' \
-e "s:Makefile in :Makefile in $src\\/:" \
-e "s:Makefile\$:Makefile in $src:")
-fi
+fi 3>&1 1>&2`
+[ $rc = 0 ] || exit 1
##
## final hints
1.450 +1 -1 apache-1.3/src/Configure
Index: Configure
===================================================================
RCS file: /home/cvs/apache-1.3/src/Configure,v
retrieving revision 1.449
retrieving revision 1.450
diff -u -r1.449 -r1.450
--- Configure 1 Feb 2002 02:27:04 -0000 1.449
+++ Configure 4 Feb 2002 13:57:39 -0000 1.450
@@ -2398,7 +2398,7 @@
echo "** Apache requires an ANSI C Compiler, such as gcc. "
echo ""
echo "======== Error Output for sanity check ========"
- (./helpers/TestCompile -v sanity)
+ (./helpers/TestCompile -v sanity) 2>&1
echo "============= End of Error Report ============="
echo ""
echo " Aborting!"
1.1767 +4 -0 apache-1.3/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/apache-1.3/src/CHANGES,v
retrieving revision 1.1766
retrieving revision 1.1767
diff -u -r1.1766 -r1.1767
--- CHANGES 1 Feb 2002 02:27:04 -0000 1.1766
+++ CHANGES 4 Feb 2002 13:57:39 -0000 1.1767
@@ -1,5 +1,9 @@
Changes with Apache 1.3.24
+ *) Fix the longstanding bug that errors (returned by src/Configure)
+ would not be noticed by the top level configure script.
+ That was bad for automated configurations. [Martin Kraemer]
+
*) Link with -lpthread on Solaris since we reference pthread
functions for the accept mutex. Previously, the link step
would succeed but we would link to bogus versions of the
Re: cvs commit: apache-1.3/src Configure CHANGES
Posted by Jeff Trawick <tr...@attglobal.net>.
martin@apache.org writes:
> martin 02/02/04 05:57:40
>
> Modified: . configure
> src Configure CHANGES
> Log:
> Fix the longstanding bug that errors (returned by src/Configure)
> would not be noticed by the top level configure script.
> That was bad for automated production environments, as errors would
> go thru unnoticed, and caused havoc much later in the production.
Thanks, folks! I just love it when the elves make a visit!
[trawick@amadeus apache-1.3]$ CFLAGS=jkalsjflkajdsflkjasdf ./configure
Configuring for Apache, Version 1.3.24-dev
...
** Apache requires an ANSI C Compiler, such as gcc.
======== Error Output for sanity check ========
cd ..; gcc -DSOLARIS2=280 -DUSE_EXPAT -I./lib/expat-lite
-DNO_DL_NEEDED jkalsjflkajdsflkjasdf `./apaci` -o helpers/dummy
helpers/dummy.c -lsocket -lnsl -lpthread
gcc: jkalsjflkajdsflkjasdf: No such file or directory
make: *** [dummy] Error 1
============= End of Error Report =============
Aborting!
[trawick@amadeus apache-1.3]$ echo $?
1 <---------cool!!!!!!!!!!!!!
[trawick@amadeus apache-1.3]$
Re: cvs commit: apache-1.3/src Configure CHANGES
Posted by Jeff Trawick <tr...@attglobal.net>.
martin@apache.org writes:
> martin 02/02/04 05:57:40
>
> Modified: . configure
> src Configure CHANGES
> Log:
> Fix the longstanding bug that errors (returned by src/Configure)
> would not be noticed by the top level configure script.
> That was bad for automated production environments, as errors would
> go thru unnoticed, and caused havoc much later in the production.
Thanks, folks! I just love it when the elves make a visit!
[trawick@amadeus apache-1.3]$ CFLAGS=jkalsjflkajdsflkjasdf ./configure
Configuring for Apache, Version 1.3.24-dev
...
** Apache requires an ANSI C Compiler, such as gcc.
======== Error Output for sanity check ========
cd ..; gcc -DSOLARIS2=280 -DUSE_EXPAT -I./lib/expat-lite
-DNO_DL_NEEDED jkalsjflkajdsflkjasdf `./apaci` -o helpers/dummy
helpers/dummy.c -lsocket -lnsl -lpthread
gcc: jkalsjflkajdsflkjasdf: No such file or directory
make: *** [dummy] Error 1
============= End of Error Report =============
Aborting!
[trawick@amadeus apache-1.3]$ echo $?
1 <---------cool!!!!!!!!!!!!!
[trawick@amadeus apache-1.3]$