You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/23 10:49:42 UTC
[GitHub] [pulsar] wuzhanpeng opened a new pull request #12158: Fix improper usage in refactoring ns-policy
wuzhanpeng opened a new pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158
A simple fix for imporper usage during code refactoring. The cause of the issue can refer to the following PRs: #5371 #12078
No doc is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#issuecomment-1055075161
@wuzhanpeng - are you able to rebase your changes here? When I approved this previously, I wasn't a committer. I am now, so I can merge this if we get it into a good place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#issuecomment-1054902894
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#discussion_r826926441
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -211,7 +211,7 @@ protected boolean isConsumersExceededOnTopic() {
Policies policies;
try {
// Use getDataIfPresent from zk cache to make the call non-blocking and prevent deadlocks
- policies = brokerService.pulsar().getPulsarResources().getNamespaceResources().getPolicies(
+ policies = brokerService.pulsar().getPulsarResources().getNamespaceResources().getPoliciesIfCached(
Review comment:
I think this one has been improved by hierarchy topic policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wuzhanpeng commented on pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
wuzhanpeng commented on pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#issuecomment-926278999
> LGTM. I see that the `isProducersExceeded` method in this class has the same logic that you're updating here. Should we fix that one too?
@michaeljmarshall Yes, thank you for your reminder, but I prefer to open another issue later to discuss about `isProducersExceeded`. That involves some other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wuzhanpeng commented on pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
wuzhanpeng commented on pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#issuecomment-925754688
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12158: Fix improper usage in refactoring ns-policy
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12158:
URL: https://github.com/apache/pulsar/pull/12158#issuecomment-926081070
@merlimat - PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org