You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nicoloboschi (via GitHub)" <gi...@apache.org> on 2023/03/31 15:55:00 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #19987: [fix][broker] Fix leader broker log
nicoloboschi opened a new pull request, #19987:
URL: https://github.com/apache/pulsar/pull/19987
### Motivation
In the broker logs this malformed message could be print by the broker
```
[main-EventThread] INFO org.apache.pulsar.broker.PulsarService - This broker is a follower. Current leader is Optional.empty
```
### Modifications
Fix proper message without calling Optional.toString
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #19987: [fix][broker] Fix leader broker log
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi merged PR #19987:
URL: https://github.com/apache/pulsar/pull/19987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19987: [fix][broker] Fix leader broker log
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19987:
URL: https://github.com/apache/pulsar/pull/19987#issuecomment-1503105195
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19987?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19987](https://codecov.io/gh/apache/pulsar/pull/19987?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e4af62) into [master](https://codecov.io/gh/apache/pulsar/commit/68c10eed7604aa3dcc3a6d8b548575e99b94dca2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68c10ee) will **decrease** coverage by `2.06%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/pulsar/pull/19987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19987 +/- ##
============================================
- Coverage 72.89% 70.84% -2.06%
- Complexity 31619 32573 +954
============================================
Files 1861 1873 +12
Lines 137356 151391 +14035
Branches 15117 18493 +3376
============================================
+ Hits 100131 107248 +7117
- Misses 29271 35438 +6167
- Partials 7954 8705 +751
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `25.98% <50.00%> (+1.55%)` | :arrow_up: |
| systests | `24.85% <50.00%> (-0.19%)` | :arrow_down: |
| unittests | `69.98% <50.00%> (-2.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pulsar/broker/PulsarService.java](https://codecov.io/gh/apache/pulsar/pull/19987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9QdWxzYXJTZXJ2aWNlLmphdmE=) | `81.77% <50.00%> (-0.02%)` | :arrow_down: |
... and [207 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/19987/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed pull request #19987: [fix][broker] Fix leader broker log
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi closed pull request #19987: [fix][broker] Fix leader broker log
URL: https://github.com/apache/pulsar/pull/19987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org