You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:15:13 UTC
[GitHub] [fineract] Grandolf49 opened a new pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Grandolf49 opened a new pull request #1283:
URL: https://github.com/apache/fineract/pull/1283
## Description
This is a backport PR for `1.4.0`. This solves FINERACT-1101 issue. Refer #1271 for more details.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680768320
@vorburger agree... would exclude the Dependabot related commits... they have verification issues and seem to be unrelated to this specific PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 closed pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
Grandolf49 closed pull request #1283:
URL: https://github.com/apache/fineract/pull/1283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680795129
> @vorburger @vidakovic I have raised a new PR #1285 for this. I mistakenly messed up the commits in my branch. I'll close this PR. Sorry for the inconvenience .
FYI for the future you can actually just work on a branch with the same name and force push, to re-use the same PR; it's both simpler for you, and easier for maintainers to have everything together in a single PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680800361
@vidakovic and @vorburger .. Will it be a bad idea for us to just merged everything on develop now and tomorrow and then rebase 1.4.0 branch on develop and freeze the release code? and everything then in develop after that goes into the next release. I feel we may get confused here and miss something. I may be wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680791161
@vorburger @vidakovic I have raised a new PR #1285 for this. I mistakenly messed up the commits in my branch. I'll close this PR. Sorry for the inconvenience .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680856421
@awasum Cherry picking is obviously just meant to be used for a short time... so I'd say we give it until the end of this week and then we should draw a line and do the release. The way that @vorburger does the backports makes sure that these things are trackable and only merged PRs (aka stuff that landed in develop) is considered.
Rebasing with current develop could be - I think - a bit problematic. We are piling more and more features into this release; maybe some of the PRs that landed in develop after the release branch was created will still need some work and/or are not tested entirely. Adding those with a rebase would just further delay things.
Next time we can avoid this by having more feedback when the release is announced (my guess is that mid-August is maybe not the best time to do this, because a lot of people might be on vacation); this time the mailing list was really quiet despite multiple reminders.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680796598
Sure @vorburger I'll keep that in mind next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1283: FINERACT-1101 [Backport PR] Swagger Codegen build using Gradle
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1283:
URL: https://github.com/apache/fineract/pull/1283#issuecomment-680857746
@alexivanov You are right and I understand you. Keep up the good work. We will get better at doing this in the future. I am also learning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org