You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by ckadner <gi...@git.apache.org> on 2017/04/26 20:42:32 UTC
[GitHub] bahir-flink pull request #16: [BAHIR-112] Build Scala, enable Scalatest and ...
GitHub user ckadner opened a pull request:
https://github.com/apache/bahir-flink/pull/16
[BAHIR-112] Build Scala, enable Scalatest and Scalastyle
Issue link: [BAHIR-112: Maven reports "No sources to compile" in flink-connector-netty](https://issues.apache.org/jira/browse/BAHIR-112)
The Maven build for *Bahir-Flink* is only set up for **Java** sources currently. However the module `flink-connector-netty` is written in **Scala**, so none of that code is being compiled, tested or verified.
This PR adds the **Scala, Scalatest, Scalastyle** maven plugins to the root `pom.xml` and modifies some of the Scala sources to comply with the enforced coding style.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ckadner/bahir-flink BAHIR-112_build_Scala_sources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 38c0c1ac386c56216d8c59343a7e4cf951601414
Author: Christian Kadner <ck...@us.ibm.com>
Date: 2017-04-26T20:30:56Z
[BAHIR-112] Build Scala sources and enable Scalatest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #16: [BAHIR-112] Build Scala, enable Scalatest and Scalast...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/16
Small comment, the license header format could be avoided, but no big deal...
Otherwise, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink pull request #16: [BAHIR-112] Build Scala, enable Scalatest and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #16: [BAHIR-112] Build Scala, enable Scalatest and Scalast...
Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:
https://github.com/apache/bahir-flink/pull/16
@lresende -- the license header is verified/enforced by Scalastyle rule
```xml
<check level="error" class="org.scalastyle.file.HeaderMatchesChecker" enabled="true">
<parameters>
<parameter name="header"><![CDATA[/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/]]></parameter>
</parameters>
</check>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #16: [BAHIR-112] Build Scala, enable Scalatest and Scalast...
Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:
https://github.com/apache/bahir-flink/pull/16
Second commit is to address **Scalastyle** check violations:
```Bash
mvn scalastyle:check -pl flink-connector-netty 2>&1 | grep "error file" | sed "s|$(pwd)||g"
```
```
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/HttpReceiverSource.scala message=File must end with newline character
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/NettyUtil.scala message=Header does not match expected text line=2
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/TcpHandler.scala message=Header does not match expected text line=2
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/TcpReceiverSource.scala message=Header does not match expected text line=2
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/TcpReceiverSource.scala message=File must end with newline character
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/TcpServer.scala message=Header does not match expected text line=2
error file=/flink-connector-netty/src/main/scala/org/apache/flink/streaming/connectors/netty/example/TcpServer.scala message=File must end with newline character
error file=/flink-connector-netty/src/test/scala/org/apache/flink/streaming/connectors/netty/example/StreamSqlExample.scala message=Header does not match expected text line=2
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---