[incubator-superset] branch master updated: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy (#5051)

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 4c44223  [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy (#5051)
4c44223 is described below

commit 4c44223234b1533660e9faa14a3de57e955b89ef
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Tue May 22 15:31:37 2018 -0700

    [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy (#5051)
---
 superset/views/core.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index cee6986..e8fc43f 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2049,9 +2049,9 @@ class Superset(BaseSupersetView):
             pass
         dashboard(dashboard_id=dash.id)
 
-        dash_edit_perm = check_ownership(dash, raise_if_false=False)
-        dash_save_perm = \
-            dash_edit_perm and security_manager.can_access('can_save_dash', 'Superset')
+        dash_edit_perm = check_ownership(dash, raise_if_false=False) and \
+            security_manager.can_access('can_save_dash', 'Superset')
+        dash_save_perm = security_manager.can_access('can_save_dash', 'Superset')
         superset_can_explore = security_manager.can_access('can_explore', 'Superset')
         slice_can_edit = security_manager.can_access('can_edit', 'SliceModelView')
 

-- 
To stop receiving notification emails like this one, please contact
graceguo@apache.org.