You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Lav Jain <lj...@pivotal.io> on 2016/04/01 00:09:53 UTC
Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
Bugs: AMBARI-15657
https://issues.apache.org/jira/browse/AMBARI-15657
Repository: ambari
Description
-------
User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
```
[pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
<property>
<name>hawq_master_directory</name>
<value>/data/hawq/master,/data/hawq/master2</value>
</property>
<property>
<name>hawq_segment_directory</name>
<value>/data/hawq/segment,/data/hawq/segment2</value>
</property>
[pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
```
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
ambari-web/app/messages.js ea06bf3
ambari-web/app/mixins/common/serverValidator.js 99a5921
ambari-web/app/models/configs/objects/service_config_property.js a437c98
ambari-web/app/styles/application.less a6b79ce
ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
Diff: https://reviews.apache.org/r/45566/diff/
Testing
-------
Manually tested the UI.
Unit test added for stack advisor.
Thanks,
Lav Jain
Re: Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
Posted by Lav Jain <lj...@pivotal.io>.
> On April 1, 2016, 3:58 a.m., Matt wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, line 972
> > <https://reviews.apache.org/r/45566/diff/1/?file=1321482#file1321482line972>
> >
> > Is trailing space valid or invalid?
> >
> > If it is valid, you may want to use strip() before splitting
Trailing spaces will be invalidated by UI.
- Lav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/#review126532
-----------------------------------------------------------
On March 31, 2016, 10:09 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45566/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:09 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-15657
> https://issues.apache.org/jira/browse/AMBARI-15657
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
> ```
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
> <property>
> <name>hawq_master_directory</name>
> <value>/data/hawq/master,/data/hawq/master2</value>
> </property>
>
> <property>
> <name>hawq_segment_directory</name>
> <value>/data/hawq/segment,/data/hawq/segment2</value>
> </property>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
> ambari-web/app/messages.js ea06bf3
> ambari-web/app/mixins/common/serverValidator.js 99a5921
> ambari-web/app/models/configs/objects/service_config_property.js a437c98
> ambari-web/app/styles/application.less a6b79ce
> ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
>
> Diff: https://reviews.apache.org/r/45566/diff/
>
>
> Testing
> -------
>
> Manually tested the UI.
>
> Unit test added for stack advisor.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
Posted by Lav Jain <lj...@pivotal.io>.
> On April 1, 2016, 3:58 a.m., Matt wrote:
> > ambari-web/app/views/common/configs/service_config_layout_tab_view.js, line 56
> > <https://reviews.apache.org/r/45566/diff/1/?file=1321489#file1321489line56>
> >
> > Can you please confirm if the help text is displayed when you hover over the directory box?
No issues with displaying the help text.
- Lav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/#review126532
-----------------------------------------------------------
On March 31, 2016, 10:09 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45566/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:09 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-15657
> https://issues.apache.org/jira/browse/AMBARI-15657
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
> ```
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
> <property>
> <name>hawq_master_directory</name>
> <value>/data/hawq/master,/data/hawq/master2</value>
> </property>
>
> <property>
> <name>hawq_segment_directory</name>
> <value>/data/hawq/segment,/data/hawq/segment2</value>
> </property>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
> ambari-web/app/messages.js ea06bf3
> ambari-web/app/mixins/common/serverValidator.js 99a5921
> ambari-web/app/models/configs/objects/service_config_property.js a437c98
> ambari-web/app/styles/application.less a6b79ce
> ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
>
> Diff: https://reviews.apache.org/r/45566/diff/
>
>
> Testing
> -------
>
> Manually tested the UI.
>
> Unit test added for stack advisor.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/#review126532
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 972)
<https://reviews.apache.org/r/45566/#comment189554>
Is trailing space valid or invalid?
If it is valid, you may want to use strip() before splitting
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 2045)
<https://reviews.apache.org/r/45566/#comment189557>
This would never fail:
problems_dict is assigned {} and is never changed.
expected_warnings is assigned {} and is never changed.
Is this required?
ambari-web/app/views/common/configs/service_config_layout_tab_view.js (line 56)
<https://reviews.apache.org/r/45566/#comment189559>
Can you please confirm if the help text is displayed when you hover over the directory box?
- Matt
On March 31, 2016, 3:09 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45566/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 3:09 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-15657
> https://issues.apache.org/jira/browse/AMBARI-15657
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
> ```
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
> <property>
> <name>hawq_master_directory</name>
> <value>/data/hawq/master,/data/hawq/master2</value>
> </property>
>
> <property>
> <name>hawq_segment_directory</name>
> <value>/data/hawq/segment,/data/hawq/segment2</value>
> </property>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
> ambari-web/app/messages.js ea06bf3
> ambari-web/app/mixins/common/serverValidator.js 99a5921
> ambari-web/app/models/configs/objects/service_config_property.js a437c98
> ambari-web/app/styles/application.less a6b79ce
> ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
>
> Diff: https://reviews.apache.org/r/45566/diff/
>
>
> Testing
> -------
>
> Manually tested the UI.
>
> Unit test added for stack advisor.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/#review126669
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On April 1, 2016, 2:39 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45566/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 2:39 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-15657
> https://issues.apache.org/jira/browse/AMBARI-15657
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
> ```
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
> <property>
> <name>hawq_master_directory</name>
> <value>/data/hawq/master,/data/hawq/master2</value>
> </property>
>
> <property>
> <name>hawq_segment_directory</name>
> <value>/data/hawq/segment,/data/hawq/segment2</value>
> </property>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
> ambari-web/app/messages.js ea06bf3
> ambari-web/app/mixins/common/serverValidator.js 99a5921
> ambari-web/app/models/configs/objects/service_config_property.js a437c98
> ambari-web/app/styles/application.less a6b79ce
> ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
>
> Diff: https://reviews.apache.org/r/45566/diff/
>
>
> Testing
> -------
>
> Manually tested the UI.
>
> Unit test added for stack advisor.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45566: HAWQ config should not allow multiple
Master/Segment directories
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45566/
-----------------------------------------------------------
(Updated April 1, 2016, 9:39 p.m.)
Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
Bugs: AMBARI-15657
https://issues.apache.org/jira/browse/AMBARI-15657
Repository: ambari
Description
-------
User can add multiple space delimited directories, but after installation, it shows a comma in between. however, only first directory goes into effect, that too with a comma in the end.
```
[pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
<property>
<name>hawq_master_directory</name>
<value>/data/hawq/master,/data/hawq/master2</value>
</property>
<property>
<name>hawq_segment_directory</name>
<value>/data/hawq/segment,/data/hawq/segment2</value>
</property>
[pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
```
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml ec7275f
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json a23afe6
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 741011c
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py d415b6f
ambari-web/app/messages.js ea06bf3
ambari-web/app/mixins/common/serverValidator.js 99a5921
ambari-web/app/models/configs/objects/service_config_property.js a437c98
ambari-web/app/styles/application.less a6b79ce
ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs f58e086
ambari-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
Diff: https://reviews.apache.org/r/45566/diff/
Testing
-------
Manually tested the UI.
Unit test added for stack advisor.
Thanks,
Lav Jain