You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:33:02 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #20036: Redesign exception hierarchy of ShardingSphere
terrymanu opened a new issue, #20036:
URL: https://github.com/apache/shardingsphere/issues/20036
The current Exception is not very clear. It is better to redesign the exception hierarchy of ShardingSphere.
1. The exception should split to ShardingSphereException which can throw to SDK layer for operation error by user, and ShardingSphereInsideException for internal catch;
1. The ShardingSphereException should include error categories and error codes, user can query like dictionary by the error categories;
1. ShardingSphereInsideException should catch by ShardingSphere and never throw to SDK directly, it can be thrown by error packet or re-throw by ShardingSphereException with error category and error code;
1. Re-throw other exceptions such as: IllegalArgumentException to ShardingSphereException.
----
The value of ShardingSphere's Kernel vendor codes should be:
`1%d`(Category)`%d%d%d`(Sequence)
Categories of Kernel:
- metadata(0)
- data(1)
- syntax(2)
- connection(3)
- transaction(4)
- lock(5)
- audit(6)
- cluster(7)
- pipeline(8)
----
The value of ShardingSphere's Feature vendor codes should be:
`2%d%d`(Feature)`%d`(Category)`%d`(Sequence)
Feature Codes:
- Sharding(0)
- Readwrite-splitting(2)
- Database-discovery(3)
- SQL translator(4)
- Traffic(5)
- Encryption(7)
- Shadow(8)
Categories of Feature:
- metadata(0,1)
- data(2,3)
- syntax(4,5)
- connection(6,7)
- algorithm(8)
- customized-algorithm(9)
----
The value of ShardingSphere's Generic vendor codes should be:
`3%d%d%d%d`(Sequence)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20036:
URL: https://github.com/apache/shardingsphere/issues/20036#issuecomment-1229610623
Hi @terrymanu , can we finish this issue in `5.1.3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #20036: Redesign exception hierarchy of ShardingSphere
URL: https://github.com/apache/shardingsphere/issues/20036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #20036:
URL: https://github.com/apache/shardingsphere/issues/20036#issuecomment-1229681111
Ok, please move it to next milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20036:
URL: https://github.com/apache/shardingsphere/issues/20036#issuecomment-1229633236
I will move this issue to `5.2.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20036: Redesign exception hierarchy of ShardingSphere
URL: https://github.com/apache/shardingsphere/issues/20036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #20036: Redesign exception hierarchy of ShardingSphere
URL: https://github.com/apache/shardingsphere/issues/20036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20036:
URL: https://github.com/apache/shardingsphere/issues/20036#issuecomment-1275435037
Since this is a long-term task, I will temporarily remove milestones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20036:
URL: https://github.com/apache/shardingsphere/issues/20036#issuecomment-1272348980
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #20036: Redesign exception hierarchy of ShardingSphere
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #20036: Redesign exception hierarchy of ShardingSphere
URL: https://github.com/apache/shardingsphere/issues/20036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org