You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/04/14 03:12:29 UTC
[GitHub] [servicecomb-service-center] DFSOrange opened a new pull request #946: fix heartbeat trigger update event problem
DFSOrange opened a new pull request #946:
URL: https://github.com/apache/servicecomb-service-center/pull/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #946: fix heartbeat trigger update event problem
Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #946:
URL: https://github.com/apache/servicecomb-service-center/pull/946#discussion_r613012920
##########
File path: datasource/mongo/sd/listwatch_inner.go
##########
@@ -71,8 +71,13 @@ func (lw *mongoListWatch) DoWatch(ctx context.Context, f func(*sdcommon.ListWatc
if resumeToken != nil {
csOptions.SetResumeAfter(resumeToken)
}
-
- resp, err := client.GetMongoClient().Watch(ctx, lw.Key, md.Pipeline{}, csOptions)
+ pipline := md.Pipeline{}
+ if lw.Key == instance {
+ // ignore instance refresh_time change event.
Review comment:
备注应该写清楚，忽略的原因，而不是描述这个行为
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui merged pull request #946: fix heartbeat trigger update event problem
Posted by GitBox <gi...@apache.org>.
little-cui merged pull request #946:
URL: https://github.com/apache/servicecomb-service-center/pull/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org