[jira] [Commented] (FLINK-9659) Remove hard-coded sleeps in bucketing sink E2E test

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523420#comment-16523420 ] 

ASF GitHub Bot commented on FLINK-9659:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6210

    [FLINK-9659][tests] Replace hard-coded sleeps

    This PR replaces hard-coded sleeps in the bucketing sink end-to-end test.
    
    Instead we use utility functions to wait for specific events, in this case some progress in the job (measured by number of checkpoints) and the job finishing (by waiting for FINISHED state).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9659

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6210
    
----
commit 15afce5b32968905972aaffd72b1f6deb126b99f
Author: zentol <ch...@...>
Date:   2018-06-25T20:19:02Z

    [FLINK-9659][tests] Replace hard-coded sleeps

----


> Remove hard-coded sleeps in bucketing sink E2E test
> ---------------------------------------------------
>
>                 Key: FLINK-9659
>                 URL: https://issues.apache.org/jira/browse/FLINK-9659
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>
> The bucketing sink end-to-end test currently uses hard-coded sleeps to a) wait for job progress and b) wait for job termination.
> Instead we can use the {{wait_num_checkpoints}} and {{wait_job_terminal_state}} utility functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)