[GitHub] [tvm] junrushao commented on a diff in pull request #15207: [TIR][Transform] Add LiftThreadBinding Pass

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao commented on code in PR #15207:
URL: https://github.com/apache/tvm/pull/15207#discussion_r1249922166


##########
include/tvm/tir/var.h:
##########
@@ -103,6 +103,12 @@ class Var : public PrimExpr {
    * \param span The location of this object in the source code.
    */
   TVM_DLL explicit Var(String name_hint, Type type_annotation, Span span = Span());
+  /*!
+   * \brief Make a new copy of var with same type, but a different nam
+   * \param name The new name to be used.
+   * \return the new Var copy
+   */
+  TVM_DLL Var copy_with_name(const String& name) const;

Review Comment:
   it follows the cnovention existing methods like `Var::copy_with_dtype`



##########
include/tvm/tir/var.h:
##########
@@ -103,6 +103,12 @@ class Var : public PrimExpr {
    * \param span The location of this object in the source code.
    */
   TVM_DLL explicit Var(String name_hint, Type type_annotation, Span span = Span());
+  /*!
+   * \brief Make a new copy of var with same type, but a different nam
+   * \param name The new name to be used.
+   * \return the new Var copy
+   */
+  TVM_DLL Var copy_with_name(const String& name) const;

Review Comment:
   it follows the convention of existing methods like `Var::copy_with_dtype`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org