You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/11/19 10:55:30 UTC
[GitHub] cloudstack pull request: [4.5] Metrics view
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1091
[4.5] Metrics view
From #1038, for 4.5 branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack metrics-4.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1091.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1091
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158326799
I am ok with merging the fix to 4.5+. I am not against that. But, missing one release is not acceptable. Given that its already merged on 4.7, merging in 4.5 now is not an option. I am ok with merging css/js improvements in 4.5+ releases.
Yes, we have been backporting fixes since a long time and thats what we are trying to change. We fix forward now.
If the upgrades are proper with minimal set of features and code change, users will upgrade. Right now they dont because its broken. They dont know if the issues fixed in the current release will be regressed in the next release. There can be hesitation for 5.0 release but 4.7 should be smooth if we fwd merge. Anyone following the release process closely will be able to figure that out (and we are doing quick releases)
Lets not change the semantics of version number (MAJOR.MINOR.PATCH)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158293387
Merging on 4.5 based on no objections and popular demands.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158313998
@remibergsma @karuturi this is confusion, we've been backporting changes for long. These are simply UI changes that don't affect backend/core/mgmt server. I would say, it helps to include them in 4.5/4.6 branches. If there is no strict rule, I want to include them in 4.5 because users are not going to simply upgrade every time we do a major release, it makes sense to backport bugfixes and small changes that can be consumed in minor releases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158329652
For future reference: this PR is reverted in commit https://github.com/apache/cloudstack/commit/ea5aecbe07f360bdf5f461c5ea2bce73c3a0e7df
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158295188
Please wait. This lands a feature/fix/enhancement in 4.5 and 4.7 while not in 4.6. This will just confuse the users.
This basically means that votes for only in 4.7 on the PR #1038 aren't valid while its already merged. We have diverged opinion here with respect to few wanting it in 4.5+ as enhancement and a few on 4.7+ as a feature. Let us not count them independently as +1. They are actually related. +1 for 4.5+ means -1 for 4.7+ and vice-versa.
We decided to fwd-merge stuff and let us please stick to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1091
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5] Metrics view
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1091#issuecomment-158313579
@karuturi I can revert the metrics view feature, but would keep the other css/js improvements wrt sorting etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---