[Bug 56682] List of Exception Management Anti-Patterns and Code Smells

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56682

--- Comment #1 from Sebb <se...@apache.org> ---
There's a slight code smell in the generated output :-)
Most of the messages have the prefix:

ANTI-PATTERN:
but some have
ANTI-PATTERN :

This can make it harder to process the results, as well as indicating possible
code duplication/corruption in the tool.

Also the summary totals at the end don't use the same wording as the individual
messages so it's not immediately obvious which total refers to which message.
This makes the summary totals harder to use.

Minor nit: the file path names use the Windows path separator (\) which can
cause issues for users on other OSes. Windows Java can use / in paths, so it is
more generally useful to use that in output that applies to multiple OSes.

Further, the output might be easier to use in a format that better suited
automatic processing. For example, CSV.

==

I've not checked all the results; there are too many.
I did not spot any obvious false positives, but whether all the antipatterns
really represent problems is another matter. The article is quite old, and
recent practice may have changed for some of the antipatterns.

-- 
You are receiving this mail because:
You are the assignee for the bug.