You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/11/18 16:44:28 UTC
svn commit: r1883610 - in
/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel:
documentinterchange/logicalstructure/ fdf/ font/ graphics/
Author: lehmi
Date: Wed Nov 18 16:44:28 2020
New Revision: 1883610
URL: http://svn.apache.org/viewvc?rev=1883610&view=rev
Log:
PDFBOX-5017: sonar fix
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFFieldTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEmbedding.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEncoding.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestTTFParser.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPatternTest.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java Wed Nov 18 16:44:28 2020
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
*
* @author Tilman Hausherr
*/
-public class PDStructureElementTest
+class PDStructureElementTest
{
private static final File TARGETPDFDIR = new File("target/pdfs");
@@ -46,7 +46,7 @@ public class PDStructureElementTest
* @throws IOException
*/
@Test
- public void testPDFBox4197() throws IOException
+ void testPDFBox4197() throws IOException
{
Set<Revisions<PDAttributeObject>> attributeSet = new HashSet<>();
try (PDDocument doc = Loader.loadPDF(new File(TARGETPDFDIR, "PDFBOX-4197.pdf")))
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java Wed Nov 18 16:44:28 2020
@@ -34,10 +34,10 @@ import org.junit.jupiter.api.Test;
* @author Johanneke Lamberink
*
*/
-public class FDFAnnotationTest
+class FDFAnnotationTest
{
@Test
- public void loadXFDFAnnotations() throws IOException, URISyntaxException
+ void loadXFDFAnnotations() throws IOException, URISyntaxException
{
File f = new File(FDFAnnotationTest.class.getResource("xfdf-test-document-annotations.xml").toURI());
try (FDFDocument fdfDoc = Loader.loadXFDF(f))
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFFieldTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFFieldTest.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFFieldTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFFieldTest.java Wed Nov 18 16:44:28 2020
@@ -34,10 +34,10 @@ import org.junit.jupiter.api.Test;
/*
* Test some characteristics of FDFFields
*/
-public class FDFFieldTest
+class FDFFieldTest
{
@Test
- public void testCOSStringValue() throws IOException
+ void testCOSStringValue() throws IOException
{
String testString = "Test value";
COSString testCOSString = new COSString(testString);
@@ -51,7 +51,7 @@ public class FDFFieldTest
@Test
- public void testTextAsCOSStreamValue() throws IOException
+ void testTextAsCOSStreamValue() throws IOException
{
String testString = "Test value";
byte[] testBytes = testString.getBytes("ASCII");
@@ -64,7 +64,7 @@ public class FDFFieldTest
}
@Test
- public void testCOSNameValue() throws IOException
+ void testCOSNameValue() throws IOException
{
String testString = "Yes";
COSName testCOSSName = COSName.getPDFName(testString);
@@ -77,7 +77,7 @@ public class FDFFieldTest
}
@Test
- public void testCOSArrayValue() throws IOException
+ void testCOSArrayValue() throws IOException
{
List<String> testList = new ArrayList<>();
testList.add("A");
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java Wed Nov 18 16:44:28 2020
@@ -53,7 +53,7 @@ import org.junit.jupiter.api.Test;
* @author adam
* @author Tilman Hausherr
*/
-public class PDFontTest
+class PDFontTest
{
private static final File OUT_DIR = new File("target/test-output");
@@ -70,7 +70,7 @@ public class PDFontTest
* @throws URISyntaxException
*/
@Test
- public void testPDFBox988() throws IOException, URISyntaxException
+ void testPDFBox988() throws IOException, URISyntaxException
{
try (PDDocument doc =
Loader.loadPDF(new File(PDFontTest.class.getResource("F001u_3_7j.pdf").toURI())))
@@ -89,7 +89,7 @@ public class PDFontTest
* @throws IOException
*/
@Test
- public void testPDFBox3747() throws IOException
+ void testPDFBox3747() throws IOException
{
File file = new File("c:/windows/fonts", "calibri.ttf");
if (!file.exists())
@@ -130,7 +130,7 @@ public class PDFontTest
* @throws URISyntaxException
*/
@Test
- public void testPDFBox3826() throws IOException, URISyntaxException
+ void testPDFBox3826() throws IOException, URISyntaxException
{
URL url = PDFont.class.getResource(
"/org/apache/pdfbox/resources/ttf/LiberationSans-Regular.ttf");
@@ -154,7 +154,7 @@ public class PDFontTest
* @throws IOException
*/
@Test
- public void testPDFBOX4115() throws IOException
+ void testPDFBOX4115() throws IOException
{
File fontFile = new File("target/fonts", "n019003l.pfb");
File outputFile = new File(OUT_DIR, "FontType1.pdf");
@@ -200,7 +200,7 @@ public class PDFontTest
* @throws java.io.IOException
*/
@Test
- public void testPDFox4318() throws IOException
+ void testPDFox4318() throws IOException
{
assertThrows(IllegalArgumentException.class,
() -> PDType1Font.HELVETICA_BOLD.encode("\u0080"),
@@ -212,7 +212,7 @@ public class PDFontTest
}
@Test
- public void testFullEmbeddingTTC() throws IOException
+ void testFullEmbeddingTTC() throws IOException
{
FontFileFinder fff = new FontFileFinder();
TrueTypeCollection ttc = null;
@@ -321,7 +321,7 @@ public class PDFontTest
* @throws IOException
*/
@Test
- public void testDeleteFont() throws IOException
+ void testDeleteFont() throws IOException
{
File tempFontFile = new File(OUT_DIR, "LiberationSans-Regular.ttf");
File tempPdfFile = new File(OUT_DIR, "testDeleteFont.pdf");
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEmbedding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEmbedding.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEmbedding.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEmbedding.java Wed Nov 18 16:44:28 2020
@@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test;
* @author John Hewson
* @author Tilman Hausherr
*/
-public class TestFontEmbedding
+class TestFontEmbedding
{
private static final File OUT_DIR = new File("target/test-output");
@@ -61,7 +61,7 @@ public class TestFontEmbedding
* @throws IOException
*/
@Test
- public void testCIDFontType2() throws IOException
+ void testCIDFontType2() throws IOException
{
validateCIDFontType2(false);
}
@@ -72,7 +72,7 @@ public class TestFontEmbedding
* @throws IOException
*/
@Test
- public void testCIDFontType2Subset() throws IOException
+ void testCIDFontType2Subset() throws IOException
{
validateCIDFontType2(true);
}
@@ -83,7 +83,7 @@ public class TestFontEmbedding
* @throws IOException
*/
@Test
- public void testCIDFontType2VerticalSubsetMonospace() throws IOException
+ void testCIDFontType2VerticalSubsetMonospace() throws IOException
{
String text = "ãABCã";
String expectedExtractedtext = "ã\nA\nB\nC\nã";
@@ -132,7 +132,7 @@ public class TestFontEmbedding
* @throws IOException
*/
@Test
- public void testCIDFontType2VerticalSubsetProportional() throws IOException
+ void testCIDFontType2VerticalSubsetProportional() throws IOException
{
String text = "ãABCã";
String expectedExtractedtext = "ã\nA\nB\nC\nã";
@@ -184,7 +184,7 @@ public class TestFontEmbedding
}
@Test
- public void testBengali() throws IOException
+ void testBengali() throws IOException
{
String BANGLA_TEXT_1 = "à¦à¦®à¦¿ à¦à§à¦¨ পথৠà¦à§à¦·à§à¦°à§à¦° লà¦à§à¦·à§à¦®à§ ষনà§à¦¡ পà§à¦¤à§à¦² রà§à¦ªà§ à¦à¦à§à¦à¦¾ à¦à¦·à¦¿";
String BANGLA_TEXT_2 = "দà§à¦°à§à¦¤ à¦à¦¾à¦¢à¦¼ শà§à¦¯à¦¼à¦¾à¦² à¦
লস à¦à§à¦à§à¦° à¦à§à¦¡à¦¼à§ à¦à¦¾à¦®à§à¦ª ধà§à¦°à§à¦¤ হঠাৠà¦à¦¾à¦à§à¦¨à¦¿ মà§à¦²à¦¿à¦ à¦à¦¶à¦¿ দà§";
@@ -237,7 +237,7 @@ public class TestFontEmbedding
* @throws java.io.IOException
*/
@Test
- public void testMaxEntries() throws IOException
+ void testMaxEntries() throws IOException
{
File file;
String text;
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEncoding.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestFontEncoding.java Wed Nov 18 16:44:28 2020
@@ -41,13 +41,13 @@ import org.junit.jupiter.api.Test;
* Tests font encoding.
*
*/
-public class TestFontEncoding
+class TestFontEncoding
{
/**
* Test the add method of a font encoding.
*/
@Test
- public void testAdd() throws Exception
+ void testAdd() throws Exception
{
// see PDFDBOX-3332
int codeForSpace = WinAnsiEncoding.INSTANCE.getNameToCodeMap().get("space");
@@ -58,7 +58,7 @@ public class TestFontEncoding
}
@Test
- public void testOverwrite() throws Exception
+ void testOverwrite() throws Exception
{
// see PDFDBOX-3332
COSDictionary dictEncodingDict = new COSDictionary();
@@ -80,7 +80,7 @@ public class TestFontEncoding
* @throws IOException
*/
@Test
- public void testPDFBox3884() throws IOException
+ void testPDFBox3884() throws IOException
{
PDDocument doc = new PDDocument();
PDPage page = new PDPage();
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestTTFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestTTFParser.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestTTFParser.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/TestTTFParser.java Wed Nov 18 16:44:28 2020
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
/**
* A test for correctly parsing TTF files.
*/
-public class TestTTFParser
+class TestTTFParser
{
/**
@@ -41,7 +41,7 @@ public class TestTTFParser
* @throws IOException if an error occurs.
*/
@Test
- public void testPostTable() throws IOException
+ void testPostTable() throws IOException
{
InputStream input = PDFont.class.getResourceAsStream(
"/org/apache/pdfbox/resources/ttf/LiberationSans-Regular.ttf");
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPatternTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPatternTest.java?rev=1883610&r1=1883609&r2=1883610&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPatternTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPatternTest.java Wed Nov 18 16:44:28 2020
@@ -31,14 +31,14 @@ import org.junit.jupiter.api.Test;
*
* @author Tilman Hausherr
*/
-public class PDLineDashPatternTest
+class PDLineDashPatternTest
{
/**
* Test of getCOSObject method, of class PDLineDashPattern.
*/
@Test
- public void testGetCOSObject()
+ void testGetCOSObject()
{
COSArray ar = new COSArray();
ar.add(COSInteger.ONE);