You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/28 19:27:12 UTC
[jira] [Commented] (GUACAMOLE-32) Extended variable support in
guacamole-docker image for linked databases
[ https://issues.apache.org/jira/browse/GUACAMOLE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305553#comment-15305553 ]
ASF GitHub Bot commented on GUACAMOLE-32:
-----------------------------------------
GitHub user vchrisb opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/10
GUACAMOLE-32: extended variable support for linked databases
- adding support for leveraging `MYSQL_ENV_MYSQL_USER`, `MYSQL_ENV_MYSQL_PASSWORD`, `MYSQL_ENV_MYSQL_DATABASE` and `MYSQL_ENV_MYSQL_ROOT_PASSWORD` for linked
- removed deprecated environmental variables `MYSQL_NAME`, `MYSQL_PORT_3306_TCP_ADDR` and `MYSQL_PORT_3306_TCP_PORT`
- adding support for leveraging `POSTGRES_ENV_POSTGRES_USER`, `$POSTGRES_ENV_POSTGRES_PASSWORD` and `POSTGRES_ENV_POSTGRES_DB` for linked
- removed deprecated environmental variables `POSTGRES_NAME`, `POSTGRES_PORT_5432_TCP_ADDR` and `POSTGRES_PORT_5432_TCP_PORT`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vchrisb/incubator-guacamole-client GUACAMOLE-32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit 20e95672e204e64182cff87ea81fa345f451f859
Author: Christopher Banck <vc...@users.noreply.github.com>
Date: 2016-05-28T19:25:55Z
GUACAMOLE-32: extended variable support for linked databases
- adding support for leveraging `MYSQL_ENV_MYSQL_USER`, `MYSQL_ENV_MYSQL_PASSWORD`, `MYSQL_ENV_MYSQL_DATABASE` and `MYSQL_ENV_MYSQL_ROOT_PASSWORD` for linked
- removed deprecated environmental variables `MYSQL_NAME`, `MYSQL_PORT_3306_TCP_ADDR` and `MYSQL_PORT_3306_TCP_PORT`
- adding support for leveraging `POSTGRES_ENV_POSTGRES_USER`, `$POSTGRES_ENV_POSTGRES_PASSWORD` and `POSTGRES_ENV_POSTGRES_DB` for linked
- removed deprecated environmental variables `POSTGRES_NAME`, `POSTGRES_PORT_5432_TCP_ADDR` and `POSTGRES_PORT_5432_TCP_PORT`
----
> Extended variable support in guacamole-docker image for linked databases
> ------------------------------------------------------------------------
>
> Key: GUACAMOLE-32
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-32
> Project: Guacamole
> Issue Type: Improvement
> Reporter: Michael Jumper
> Priority: Minor
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from [GUAC-1545|https://glyptodon.org/jira/browse/GUAC-1545], an issue in the JIRA instance used by the Guacamole project prior to its acceptance into the Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance *have not been copied* and can be found instead at the original issue.
> {panel}
> The current Guacamole Docker image has some issues related to environment variables:
> # The link environmental variables, like {{MYSQL_PORT_3306_TCP_ADDR}}, are deprecated (see the [link environment variables reference|https://docs.docker.com/compose/link-env-deprecated/]). The name of the service, or alias, should be used to connect instead.
> # The current docker image is not leveraging all of the environmental variables of the linked database container. (e.g. {{MYSQL_ENV_MYSQL_USER}})
> # The current name of the environmental variables {{MYSQL_PORT}} and {{POSTGRES_PORT}} are not the best choice, because they are also used by Docker (though deprecated) for specifying the full connection URL to the linked container. e.g. {{tcp://172.17.0.5:5432}}
> I've created a pull request implementing the following changes:
> - Adding support for leveraging {{MYSQL_ENV_MYSQL_USER}}, {{MYSQL_ENV_MYSQL_PASSWORD}}, {{MYSQL_ENV_MYSQL_DATABASE}} and {{MYSQL_ENV_MYSQL_ROOT_PASSWORD}} for linked
> - Removed deprecated environmental variables {{MYSQL_NAME}}, {{MYSQL_PORT_3306_TCP_ADDR}} and {{MYSQL_PORT_3306_TCP_PORT}}
> - Adding support for leveraging {{POSTGRES_ENV_POSTGRES_USER}}, {{POSTGRES_ENV_POSTGRES_PASSWORD}} and {{POSTGRES_ENV_POSTGRES_DB}} for linked
> - Removed deprecated environmental variables {{POSTGRES_NAME}}, {{POSTGRES_PORT_5432_TCP_ADDR}} and {{POSTGRES_PORT_5432_TCP_PORT}}
> The modified branch can be found here:
> https://github.com/vchrisb/guacamole-docker/tree/linked-db-envs
> The modified Docker image is {{vchrisb/guacamole:linked-db-envs}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)