You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Wes McKinney <we...@gmail.com> on 2020/05/04 23:17:34 UTC
[DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
hi folks,
We have accumulated a few regressions
ARROW-8657 https://github.com/apache/arrow/pull/7089
ARROW-8694 https://github.com/apache/arrow/pull/7103
there may be a few others.
I think we should try to make a "streamlined" patch release (after
surveying incoming bug reports for other serious regressions) if
possible focused on providing patched binaries to the impacted users
(in the above, this would be any user of the Parquet portion of the
C++ library). The hope would be to be able to trim down the work
required of a release manager in a normal major release in these
scenarios where we need to get out bugfixes sooner.
Thoughts?
Thanks
Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Krisztián Szűcs <sz...@gmail.com>.
Just pushed the maint-0.17.x branch - I had conflicts here and there.
Applied the following git commands:
https://gist.github.com/kszucs/ea75f09090a9ffdff07e51582af1f436
Submitted the corssbow packaging tasks to see nothing is missing.
I'll start with cutting RC0 tomorrow.
On Mon, May 11, 2020 at 7:23 PM Krisztián Szűcs
<sz...@gmail.com> wrote:
>
> On Fri, May 8, 2020 at 9:58 PM Wes McKinney <we...@gmail.com> wrote:
> >
> > From the release milestone
> > (https://issues.apache.org/jira/projects/ARROW/versions/12348202) it
> > looks like there are a few remaining issues
> >
> > ARROW-8684 -- there is a PR but we don't understand why it works. If
> > we can't figure it out but the patch fixes the broken wheel issue we
> > may have to accept it for now
> > ARROW-8741: in progress
> > ARROW-8726: No patch yet available (does this need to block? since
> > this is a bug in bleeding edge functionality)
> >
> > Who would be able to cut the patch release? Do you think it will be
> > possible to reduce the steps involved with producing this release to
> > ease the work required of the RM?
> I'll do it.
>
> The patch release affects all of the C++ based packages we cannot really skip
> any steps of creating a release candidate but we can spare a couple of post
> release steps to not ship unaffected implementations.
>
> Additionally we'll need to include multiple packaging related patches to have
> passing build - I'm going through the changelog.
>
> >
> > On Thu, May 7, 2020 at 7:30 AM Antoine Pitrou <an...@python.org> wrote:
> > >
> > >
> > > There's also ARROW-8728 and ARROW-8704.
> > >
> > > Regards
> > >
> > > Antoine.
> > >
> > >
> > > Le 07/05/2020 à 14:25, Francois Saint-Jacques a écrit :
> > > > I'll add https://issues.apache.org/jira/browse/ARROW-8726 to the list.
> > > >
> > > > On Tue, May 5, 2020 at 6:52 PM Wes McKinney <we...@gmail.com> wrote:
> > > >>
> > > >> Sorry I haven't had enough coffee today.
> > > >>
> > > >> The patches that still need to be resolved AFAICT are ARROW-8684 and
> > > >> ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
> > > >>
> > > >> On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
> > > >>>
> > > >>> I just added it to the milestone in JIRA. In general if you want to
> > > >>> add a patch to a patch release, you can go into JIRA and add the fix
> > > >>> version
> > > >>>
> > > >>> I think the most critical patches have all been merged now, is there a
> > > >>> reason to delay much longer in cutting a release? We might use the
> > > >>> opportunity to produce a slimmed down "Release Management for Patch
> > > >>> Releases" guide with some steps omitted (hopefully)
> > > >>>
> > > >>> On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
> > > >>>>
> > > >>>> Would it be possible to include the variant.hpp update
> > > >>>> <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
> > > >>>>
> > > >>>> Thanks,
> > > >>>>
> > > >>>> Paul
> > > >>>>
> > > >>>> On 5/4/20 4:17 PM, Wes McKinney wrote:
> > > >>>>> hi folks,
> > > >>>>>
> > > >>>>> We have accumulated a few regressions
> > > >>>>>
> > > >>>>> ARROW-8657 https://github.com/apache/arrow/pull/7089
> > > >>>>> ARROW-8694 https://github.com/apache/arrow/pull/7103
> > > >>>>>
> > > >>>>> there may be a few others.
> > > >>>>>
> > > >>>>> I think we should try to make a "streamlined" patch release (after
> > > >>>>> surveying incoming bug reports for other serious regressions) if
> > > >>>>> possible focused on providing patched binaries to the impacted users
> > > >>>>> (in the above, this would be any user of the Parquet portion of the
> > > >>>>> C++ library). The hope would be to be able to trim down the work
> > > >>>>> required of a release manager in a normal major release in these
> > > >>>>> scenarios where we need to get out bugfixes sooner.
> > > >>>>>
> > > >>>>> Thoughts?
> > > >>>>>
> > > >>>>> Thanks
> > > >>>>> Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Krisztián Szűcs <sz...@gmail.com>.
On Fri, May 8, 2020 at 9:58 PM Wes McKinney <we...@gmail.com> wrote:
>
> From the release milestone
> (https://issues.apache.org/jira/projects/ARROW/versions/12348202) it
> looks like there are a few remaining issues
>
> ARROW-8684 -- there is a PR but we don't understand why it works. If
> we can't figure it out but the patch fixes the broken wheel issue we
> may have to accept it for now
> ARROW-8741: in progress
> ARROW-8726: No patch yet available (does this need to block? since
> this is a bug in bleeding edge functionality)
>
> Who would be able to cut the patch release? Do you think it will be
> possible to reduce the steps involved with producing this release to
> ease the work required of the RM?
I'll do it.
The patch release affects all of the C++ based packages we cannot really skip
any steps of creating a release candidate but we can spare a couple of post
release steps to not ship unaffected implementations.
Additionally we'll need to include multiple packaging related patches to have
passing build - I'm going through the changelog.
>
> On Thu, May 7, 2020 at 7:30 AM Antoine Pitrou <an...@python.org> wrote:
> >
> >
> > There's also ARROW-8728 and ARROW-8704.
> >
> > Regards
> >
> > Antoine.
> >
> >
> > Le 07/05/2020 à 14:25, Francois Saint-Jacques a écrit :
> > > I'll add https://issues.apache.org/jira/browse/ARROW-8726 to the list.
> > >
> > > On Tue, May 5, 2020 at 6:52 PM Wes McKinney <we...@gmail.com> wrote:
> > >>
> > >> Sorry I haven't had enough coffee today.
> > >>
> > >> The patches that still need to be resolved AFAICT are ARROW-8684 and
> > >> ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
> > >>
> > >> On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
> > >>>
> > >>> I just added it to the milestone in JIRA. In general if you want to
> > >>> add a patch to a patch release, you can go into JIRA and add the fix
> > >>> version
> > >>>
> > >>> I think the most critical patches have all been merged now, is there a
> > >>> reason to delay much longer in cutting a release? We might use the
> > >>> opportunity to produce a slimmed down "Release Management for Patch
> > >>> Releases" guide with some steps omitted (hopefully)
> > >>>
> > >>> On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
> > >>>>
> > >>>> Would it be possible to include the variant.hpp update
> > >>>> <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
> > >>>>
> > >>>> Thanks,
> > >>>>
> > >>>> Paul
> > >>>>
> > >>>> On 5/4/20 4:17 PM, Wes McKinney wrote:
> > >>>>> hi folks,
> > >>>>>
> > >>>>> We have accumulated a few regressions
> > >>>>>
> > >>>>> ARROW-8657 https://github.com/apache/arrow/pull/7089
> > >>>>> ARROW-8694 https://github.com/apache/arrow/pull/7103
> > >>>>>
> > >>>>> there may be a few others.
> > >>>>>
> > >>>>> I think we should try to make a "streamlined" patch release (after
> > >>>>> surveying incoming bug reports for other serious regressions) if
> > >>>>> possible focused on providing patched binaries to the impacted users
> > >>>>> (in the above, this would be any user of the Parquet portion of the
> > >>>>> C++ library). The hope would be to be able to trim down the work
> > >>>>> required of a release manager in a normal major release in these
> > >>>>> scenarios where we need to get out bugfixes sooner.
> > >>>>>
> > >>>>> Thoughts?
> > >>>>>
> > >>>>> Thanks
> > >>>>> Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Wes McKinney <we...@gmail.com>.
From the release milestone
(https://issues.apache.org/jira/projects/ARROW/versions/12348202) it
looks like there are a few remaining issues
ARROW-8684 -- there is a PR but we don't understand why it works. If
we can't figure it out but the patch fixes the broken wheel issue we
may have to accept it for now
ARROW-8741: in progress
ARROW-8726: No patch yet available (does this need to block? since
this is a bug in bleeding edge functionality)
Who would be able to cut the patch release? Do you think it will be
possible to reduce the steps involved with producing this release to
ease the work required of the RM?
On Thu, May 7, 2020 at 7:30 AM Antoine Pitrou <an...@python.org> wrote:
>
>
> There's also ARROW-8728 and ARROW-8704.
>
> Regards
>
> Antoine.
>
>
> Le 07/05/2020 à 14:25, Francois Saint-Jacques a écrit :
> > I'll add https://issues.apache.org/jira/browse/ARROW-8726 to the list.
> >
> > On Tue, May 5, 2020 at 6:52 PM Wes McKinney <we...@gmail.com> wrote:
> >>
> >> Sorry I haven't had enough coffee today.
> >>
> >> The patches that still need to be resolved AFAICT are ARROW-8684 and
> >> ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
> >>
> >> On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
> >>>
> >>> I just added it to the milestone in JIRA. In general if you want to
> >>> add a patch to a patch release, you can go into JIRA and add the fix
> >>> version
> >>>
> >>> I think the most critical patches have all been merged now, is there a
> >>> reason to delay much longer in cutting a release? We might use the
> >>> opportunity to produce a slimmed down "Release Management for Patch
> >>> Releases" guide with some steps omitted (hopefully)
> >>>
> >>> On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
> >>>>
> >>>> Would it be possible to include the variant.hpp update
> >>>> <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Paul
> >>>>
> >>>> On 5/4/20 4:17 PM, Wes McKinney wrote:
> >>>>> hi folks,
> >>>>>
> >>>>> We have accumulated a few regressions
> >>>>>
> >>>>> ARROW-8657 https://github.com/apache/arrow/pull/7089
> >>>>> ARROW-8694 https://github.com/apache/arrow/pull/7103
> >>>>>
> >>>>> there may be a few others.
> >>>>>
> >>>>> I think we should try to make a "streamlined" patch release (after
> >>>>> surveying incoming bug reports for other serious regressions) if
> >>>>> possible focused on providing patched binaries to the impacted users
> >>>>> (in the above, this would be any user of the Parquet portion of the
> >>>>> C++ library). The hope would be to be able to trim down the work
> >>>>> required of a release manager in a normal major release in these
> >>>>> scenarios where we need to get out bugfixes sooner.
> >>>>>
> >>>>> Thoughts?
> >>>>>
> >>>>> Thanks
> >>>>> Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Antoine Pitrou <an...@python.org>.
There's also ARROW-8728 and ARROW-8704.
Regards
Antoine.
Le 07/05/2020 à 14:25, Francois Saint-Jacques a écrit :
> I'll add https://issues.apache.org/jira/browse/ARROW-8726 to the list.
>
> On Tue, May 5, 2020 at 6:52 PM Wes McKinney <we...@gmail.com> wrote:
>>
>> Sorry I haven't had enough coffee today.
>>
>> The patches that still need to be resolved AFAICT are ARROW-8684 and
>> ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
>>
>> On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
>>>
>>> I just added it to the milestone in JIRA. In general if you want to
>>> add a patch to a patch release, you can go into JIRA and add the fix
>>> version
>>>
>>> I think the most critical patches have all been merged now, is there a
>>> reason to delay much longer in cutting a release? We might use the
>>> opportunity to produce a slimmed down "Release Management for Patch
>>> Releases" guide with some steps omitted (hopefully)
>>>
>>> On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
>>>>
>>>> Would it be possible to include the variant.hpp update
>>>> <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
>>>>
>>>> Thanks,
>>>>
>>>> Paul
>>>>
>>>> On 5/4/20 4:17 PM, Wes McKinney wrote:
>>>>> hi folks,
>>>>>
>>>>> We have accumulated a few regressions
>>>>>
>>>>> ARROW-8657 https://github.com/apache/arrow/pull/7089
>>>>> ARROW-8694 https://github.com/apache/arrow/pull/7103
>>>>>
>>>>> there may be a few others.
>>>>>
>>>>> I think we should try to make a "streamlined" patch release (after
>>>>> surveying incoming bug reports for other serious regressions) if
>>>>> possible focused on providing patched binaries to the impacted users
>>>>> (in the above, this would be any user of the Parquet portion of the
>>>>> C++ library). The hope would be to be able to trim down the work
>>>>> required of a release manager in a normal major release in these
>>>>> scenarios where we need to get out bugfixes sooner.
>>>>>
>>>>> Thoughts?
>>>>>
>>>>> Thanks
>>>>> Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Francois Saint-Jacques <fs...@gmail.com>.
I'll add https://issues.apache.org/jira/browse/ARROW-8726 to the list.
On Tue, May 5, 2020 at 6:52 PM Wes McKinney <we...@gmail.com> wrote:
>
> Sorry I haven't had enough coffee today.
>
> The patches that still need to be resolved AFAICT are ARROW-8684 and
> ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
>
> On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
> >
> > I just added it to the milestone in JIRA. In general if you want to
> > add a patch to a patch release, you can go into JIRA and add the fix
> > version
> >
> > I think the most critical patches have all been merged now, is there a
> > reason to delay much longer in cutting a release? We might use the
> > opportunity to produce a slimmed down "Release Management for Patch
> > Releases" guide with some steps omitted (hopefully)
> >
> > On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
> > >
> > > Would it be possible to include the variant.hpp update
> > > <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
> > >
> > > Thanks,
> > >
> > > Paul
> > >
> > > On 5/4/20 4:17 PM, Wes McKinney wrote:
> > > > hi folks,
> > > >
> > > > We have accumulated a few regressions
> > > >
> > > > ARROW-8657 https://github.com/apache/arrow/pull/7089
> > > > ARROW-8694 https://github.com/apache/arrow/pull/7103
> > > >
> > > > there may be a few others.
> > > >
> > > > I think we should try to make a "streamlined" patch release (after
> > > > surveying incoming bug reports for other serious regressions) if
> > > > possible focused on providing patched binaries to the impacted users
> > > > (in the above, this would be any user of the Parquet portion of the
> > > > C++ library). The hope would be to be able to trim down the work
> > > > required of a release manager in a normal major release in these
> > > > scenarios where we need to get out bugfixes sooner.
> > > >
> > > > Thoughts?
> > > >
> > > > Thanks
> > > > Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Wes McKinney <we...@gmail.com>.
Sorry I haven't had enough coffee today.
The patches that still need to be resolved AFAICT are ARROW-8684 and
ARROW-8706 (AKA PARQUET-1857), so it will take a little while yet
On Tue, May 5, 2020 at 5:18 PM Wes McKinney <we...@gmail.com> wrote:
>
> I just added it to the milestone in JIRA. In general if you want to
> add a patch to a patch release, you can go into JIRA and add the fix
> version
>
> I think the most critical patches have all been merged now, is there a
> reason to delay much longer in cutting a release? We might use the
> opportunity to produce a slimmed down "Release Management for Patch
> Releases" guide with some steps omitted (hopefully)
>
> On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
> >
> > Would it be possible to include the variant.hpp update
> > <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
> >
> > Thanks,
> >
> > Paul
> >
> > On 5/4/20 4:17 PM, Wes McKinney wrote:
> > > hi folks,
> > >
> > > We have accumulated a few regressions
> > >
> > > ARROW-8657 https://github.com/apache/arrow/pull/7089
> > > ARROW-8694 https://github.com/apache/arrow/pull/7103
> > >
> > > there may be a few others.
> > >
> > > I think we should try to make a "streamlined" patch release (after
> > > surveying incoming bug reports for other serious regressions) if
> > > possible focused on providing patched binaries to the impacted users
> > > (in the above, this would be any user of the Parquet portion of the
> > > C++ library). The hope would be to be able to trim down the work
> > > required of a release manager in a normal major release in these
> > > scenarios where we need to get out bugfixes sooner.
> > >
> > > Thoughts?
> > >
> > > Thanks
> > > Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Wes McKinney <we...@gmail.com>.
I just added it to the milestone in JIRA. In general if you want to
add a patch to a patch release, you can go into JIRA and add the fix
version
I think the most critical patches have all been merged now, is there a
reason to delay much longer in cutting a release? We might use the
opportunity to produce a slimmed down "Release Management for Patch
Releases" guide with some steps omitted (hopefully)
On Tue, May 5, 2020 at 2:55 PM Paul Taylor <pt...@gmail.com> wrote:
>
> Would it be possible to include the variant.hpp update
> <https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
>
> Thanks,
>
> Paul
>
> On 5/4/20 4:17 PM, Wes McKinney wrote:
> > hi folks,
> >
> > We have accumulated a few regressions
> >
> > ARROW-8657 https://github.com/apache/arrow/pull/7089
> > ARROW-8694 https://github.com/apache/arrow/pull/7103
> >
> > there may be a few others.
> >
> > I think we should try to make a "streamlined" patch release (after
> > surveying incoming bug reports for other serious regressions) if
> > possible focused on providing patched binaries to the impacted users
> > (in the above, this would be any user of the Parquet portion of the
> > C++ library). The hope would be to be able to trim down the work
> > required of a release manager in a normal major release in these
> > scenarios where we need to get out bugfixes sooner.
> >
> > Thoughts?
> >
> > Thanks
> > Wes
Re: [DISCUSS] Need for Arrow 0.17.1 patch release (binary only?)
Posted by Paul Taylor <pt...@gmail.com>.
Would it be possible to include the variant.hpp update
<https://github.com/apache/arrow/pull/7053> for nvcc in 0.17.1?
Thanks,
Paul
On 5/4/20 4:17 PM, Wes McKinney wrote:
> hi folks,
>
> We have accumulated a few regressions
>
> ARROW-8657 https://github.com/apache/arrow/pull/7089
> ARROW-8694 https://github.com/apache/arrow/pull/7103
>
> there may be a few others.
>
> I think we should try to make a "streamlined" patch release (after
> surveying incoming bug reports for other serious regressions) if
> possible focused on providing patched binaries to the impacted users
> (in the above, this would be any user of the Parquet portion of the
> C++ library). The hope would be to be able to trim down the work
> required of a release manager in a normal major release in these
> scenarios where we need to get out bugfixes sooner.
>
> Thoughts?
>
> Thanks
> Wes