You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2009/01/29 14:44:59 UTC

[jira] Created: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

[jdktools] javac should exit with error code non-zero on compile errors
-----------------------------------------------------------------------

                 Key: HARMONY-6079
                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
             Project: Harmony
          Issue Type: Bug
          Components: JDK
            Reporter: Mark Hindess
            Priority: Minor


javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670303#action_12670303 ] 

Tim Ellison commented on HARMONY-6079:
--------------------------------------

The javac tool page [1] doesn't define the return codes.  Playing around a bit with the RI it would appear
return 0 = success
return 1 = compile error / unrecognized option
return 2 = no args given, usage printed

I'll recreate those return codes unless you see any better definition.

[1] http://java.sun.com/j2se/1.5.0/docs/tooldocs/solaris/javac.html

> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Pervov reopened HARMONY-6079:
-----------------------------------


Tim, bad luck.

Your changes break building the javac tool.

> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-6079.
----------------------------------

    Resolution: Fixed

Thanks Pavel, erm, I was testing the Hudson build server - honest :-)

Actually, I didn't do a "clean" before my build, and the dependency didn't pick up the reference from our com.sun code.

Fixed at r740721.

> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess closed HARMONY-6079.
---------------------------------


Verified.  Thanks Tim.


> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-6079:
------------------------------------

    Assignee: Tim Ellison

> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669149#action_12669149 ] 

Nathan Beyer commented on HARMONY-6079:
---------------------------------------

+1

> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6079) [jdktools] javac should exit with error code non-zero on compile errors

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-6079.
----------------------------------

    Resolution: Fixed

Mark,

Please test with builds > r740696 and see if that is the behavior you are expecting.


> [jdktools] javac should exit with error code non-zero on compile errors
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-6079
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6079
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>            Reporter: Mark Hindess
>            Assignee: Tim Ellison
>            Priority: Minor
>
> javac currently always exits with error code zero even if there are compile errors.  Sun javac exits with non-zero error code which is useful when javac is used from scripts and Makefiles.  I think we should adopt Sun javac behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.