[GitHub] [spark] bart-samwel commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

[GitBox <gi...@apache.org>]

bart-samwel commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-654708664


   Thinking about this some more, there may actually be something more important, which is compatibility with [named arguments](https://docs.scala-lang.org/tour/named-arguments.html). The names in the docs should probably match the names in the code. And we can't change the names in the code because of API compatibility -- existing callers may refer to them using named arguments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org