You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/27 02:57:38 UTC
[kudu-CR] thirdparty: fix memkind build on el6 machines
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13440
to review the following change.
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
thirdparty: fix memkind build on el6 machines
- The configure.ac shipped with the bundled jemalloc generates a broken
configure script when invoked with autoconf 2.63 (i.e. the version of
autoconf found on el6. Here's a patch that works around the issue and
allows the build to proceed.
- The configure.ac in memkind requires autoconf 2.64. With a little
finagling, we can drop that dependency to 2.63.
- The memkind build assumes that clock_gettime (needed by jemalloc) is found
in glibc, but that's only true for new versions of glibc. In old versions,
it's actually in librt. [1]
1. https://github.com/memkind/memkind/issues/48
Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/memkind-fix-build-with-old-autoconf.patch
A thirdparty/patches/memkind-fix-build-with-old-glibc.patch
A thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
4 files changed, 97 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13440/1
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, ye yuqiang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13440
to look at the new patch set (#2).
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
thirdparty: fix memkind build on el6 machines
- The configure.ac shipped with the bundled jemalloc generates a broken
configure script when invoked with autoconf 2.63 (i.e. the version of
autoconf found on el6). Here's a patch that works around the issue and
allows the build to proceed.
- The configure.ac in memkind requires autoconf 2.64. With a little
finagling, we can drop that dependency to 2.63.
- The memkind build assumes that clock_gettime (needed by jemalloc) is found
in glibc, but that's only true for new versions of glibc. In old versions,
it's actually in librt. [1]
1. https://github.com/memkind/memkind/issues/48
Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/memkind-fix-build-with-old-autoconf.patch
A thirdparty/patches/memkind-fix-build-with-old-glibc.patch
A thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
4 files changed, 97 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13440/2
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11
PS1, Line 11: autoconf found on el6. Here's a patch that works around the issue and
nit: add closing parenthesis ')'
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
File thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch:
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch@26
PS1, Line 26: + AC_CHECK_HEADERS([dlfcn.h], , [have_dlsym="0"])
nit: add [] to follow the style in other AC macros?
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 19:13:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 22:12:15 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
File thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch:
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch@26
PS1, Line 26: + AC_CHECK_HEADERS([dlfcn.h], , [have_dlsym="0"])
> Some of the other instances of this pattern in jemalloc's configure.ac do t
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 22:12:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11
PS1, Line 11: el6)
> close parens
Done
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11
PS1, Line 11: autoconf found on el6). Here's a patch that works around the issue and
> nit: add closing parenthesis ')'
Done
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
File thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch:
http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch@26
PS1, Line 26: + AC_CHECK_HEADERS([dlfcn.h], , [have_dlsym="0"])
> nit: add [] to follow the style in other AC macros?
Some of the other instances of this pattern in jemalloc's configure.ac do the same thing, so I'll leave it as-is.
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 22:10:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
thirdparty: fix memkind build on el6 machines
- The configure.ac shipped with the bundled jemalloc generates a broken
configure script when invoked with autoconf 2.63 (i.e. the version of
autoconf found on el6). Here's a patch that works around the issue and
allows the build to proceed.
- The configure.ac in memkind requires autoconf 2.64. With a little
finagling, we can drop that dependency to 2.63.
- The memkind build assumes that clock_gettime (needed by jemalloc) is found
in glibc, but that's only true for new versions of glibc. In old versions,
it's actually in librt. [1]
1. https://github.com/memkind/memkind/issues/48
Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Reviewed-on: http://gerrit.cloudera.org:8080/13440
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/memkind-fix-build-with-old-autoconf.patch
A thirdparty/patches/memkind-fix-build-with-old-glibc.patch
A thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
4 files changed, 97 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] thirdparty: fix memkind build on el6 machines
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11
PS1, Line 11: el6.
close parens
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 19:19:08 +0000
Gerrit-HasComments: Yes