[GitHub] nzomkxia closed pull request #122: Fix AceEditor width/height config 'px' suffix

[GitBox <gi...@apache.org>]

nzomkxia closed pull request #122: Fix AceEditor width/height config 'px' suffix
URL: https://github.com/apache/incubator-dubbo-ops/pull/122
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-admin-frontend/src/components/AceEditor.vue b/dubbo-admin-frontend/src/components/AceEditor.vue
index bab63b7..1d58ef0 100644
--- a/dubbo-admin-frontend/src/components/AceEditor.vue
+++ b/dubbo-admin-frontend/src/components/AceEditor.vue
@@ -16,7 +16,7 @@
   -->
 
 <template>
-  <div :style="{height: myConfig.height + 'px', width: myConfig.width + 'px'}"></div>
+  <div :style="{height: myConfig.height, width: myConfig.width}"></div>
 </template>
 
 <script>
@@ -24,7 +24,7 @@ import brace from 'brace'
 
 let defaultConfig = {
   width: '100%',
-  height: 300,
+  height: '300px',
   lang: 'yaml',
   theme: 'monokai',
   readonly: false,


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org