You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/28 05:34:28 UTC
[GitHub] [airflow] dstandish opened a new pull request, #28616: Reduce logging level of `gunicorn.access` to warning
dstandish opened a new pull request, #28616:
URL: https://github.com/apache/airflow/pull/28616
When running webserver in debug mode, we can control this with airflow_local_settings because it's in-process. But in production mode, gunicorn workers run in subprocesses, and we have to set this within the process.
We could make this configurable. But, I'm not sure it's necessary. Maybe we don't, and then do if asked?
The type of message this filters out is this:
```
127.0.0.1 - - [27/Dec/2022:19:22:58 -0800] "GET /static/appbuilder/datepicker/bootstrap-datepicker.js HTTP/1.1" 304 0 "http://localhost:8080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
127.0.0.1 - - [27/Dec/2022:19:22:58 -0800] "GET /static/appbuilder/select2/select2.js HTTP/1.1" 304 0 "http://localhost:8080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
127.0.0.1 - - [27/Dec/2022:19:22:58 -0800] "GET /static/appbuilder/js/ab.js HTTP/1.1" 304 0 "http://localhost:8080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
127.0.0.1 - - [27/Dec/2022:19:22:58 -0800] "GET /static/dist/moment.197a6f3cab42e240f8bd.js HTTP/1.1" 304 0 "http://localhost:8080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
127.0.0.1 - - [27/Dec/2022:19:22:58 -0800] "GET /static/dist/main.f64802c246d907b57425.js HTTP/1.1" 304 0 "http://localhost:8080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
```
It tends to be a lot, and it's not usually something that we care about AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #28616: Reduce logging level of `gunicorn.access` to warning
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #28616: Reduce logging level of `gunicorn.access` to warning
URL: https://github.com/apache/airflow/pull/28616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #28616:
URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366477472
Ah interesting ... thanks for that. Now the behavior makes a lot more sense. Setting to empty string works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #28616:
URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366436390
> https://docs.gunicorn.org/en/stable/settings.html
Sorry which config? What would you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28616:
URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366386668
Is the intention to simply disable access logs? There’s actually a separate config for that. Also maybe it’d not be a bad idea to log those to a file instead? Either would be better than disabling all INFO logs entirely. https://docs.gunicorn.org/en/stable/settings.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28616:
URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366454296
I took a look at the surrounding code and it seems that access logs are currently explicitly enabled by whoever implemented it in the first place. Gunicorn does not emit access logs unless you specify `--access-logfile`, which Airflow does here:
https://github.com/apache/airflow/blob/467a5e3ab287013db2a5381ef4a642e912f8b45b/airflow/cli/commands/webserver_command.py#L405-L406
and there’s no way to turn if off since `args.access_logfile` has a hard-coded default of `-` (send to stdout).
If we want to make the stdout log less verbose, perhaps we should simply change the default of `access_logfile` to an empty string? Or maybe we should respect whoever implemented this and keep the current logging…?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org