[GitHub] [hudi] xushiyan commented on a diff in pull request #5641: [HUDI-4023] Decouple hudi-spark from hudi-utilities-slim-bundle

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #5641:
URL: https://github.com/apache/hudi/pull/5641#discussion_r881405148


##########
packaging/hudi-utilities-slim-bundle/README.md:
##########
@@ -17,6 +17,89 @@
 
 # Usage of hudi-utilities-slim-bundle
 
-Starting from versions 0.11, Hudi provides hudi-utilities-slim-bundle which excludes hudi-spark-datasource modules.
-This new bundle is intended to be used with Hudi Spark bundle together, if using hudi-utilities-bundle solely
-introduces problems for a specific Spark version.
\ No newline at end of file
+Starting from versions 0.11, Hudi provides hudi-utilities-slim-bundle which excludes hudi-spark-datasource modules. This new bundle is intended to be used with Hudi Spark bundle together, if using
+hudi-utilities-bundle solely introduces problems for a specific Spark version.
+
+## Example with Spark 2.4.7

Review Comment:
   should this be moved to asf-site as part of 0.12 update?



##########
packaging/hudi-utilities-slim-bundle/pom.xml:
##########
@@ -92,9 +92,7 @@
                 <includes>
                   <include>org.apache.hudi:hudi-common</include>
                   <include>org.apache.hudi:hudi-client-common</include>
-                  <include>org.apache.hudi:hudi-spark-client</include>
                   <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include>
-                  <include>org.apache.hudi:hudi-hive-sync</include>
                   <include>org.apache.hudi:hudi-sync-common</include>

Review Comment:
   sync-common should also be removed too? by right, the user-chosen metasync bundle should have it



##########
pom.xml:
##########
@@ -557,6 +558,11 @@
         <artifactId>jersey-container-servlet-core</artifactId>
         <version>${glassfish.version}</version>
       </dependency>
+      <dependency>

Review Comment:
   ok but does this have to be the default compile scope ?



##########
packaging/hudi-utilities-slim-bundle/pom.xml:
##########
@@ -136,13 +134,6 @@
                   <include>org.apache.kafka:kafka_${scala.binary.version}</include>
                   <include>com.101tec:zkclient</include>
                   <include>org.apache.kafka:kafka-clients</include>
-
-                  <include>org.apache.hive:hive-common</include>
-                  <include>org.apache.hive:hive-service</include>
-                  <include>org.apache.hive:hive-service-rpc</include>
-                  <include>org.apache.hive:hive-metastore</include>
-                  <include>org.apache.hive:hive-jdbc</include>

Review Comment:
   i saw the relocations still shading hive.jdbc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org