You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by an...@apache.org on 2005/12/31 16:22:15 UTC
svn commit: r360290 - in /cocoon/trunk/src/java/org/apache/cocoon:
components/modules/output/SessionAttributeOutputModule.java
xml/dom/DOMStreamer.java
Author: antonio
Date: Sat Dec 31 07:22:11 2005
New Revision: 360290
URL: http://svn.apache.org/viewcvs?rev=360290&view=rev
Log:
Compares Strings using equals()
Modified:
cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java
cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java
Modified: cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java?rev=360290&r1=360289&r2=360290&view=diff
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java (original)
+++ cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java Sat Dec 31 07:22:11 2005
@@ -124,7 +124,7 @@
getLogger().debug("done rolling back");
String prefix = (String) this.settings.get("key-prefix", PREFIX );
- if (prefix!="") {
+ if (!(prefix.equals(""))) {
ObjectModelHelper.getRequest(objectModel).getSession().setAttribute(prefix+":",e.getMessage());
} else {
ObjectModelHelper.getRequest(objectModel).getSession().setAttribute("errorMessage",e.getMessage());
Modified: cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java?rev=360290&r1=360289&r2=360290&view=diff
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java (original)
+++ cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java Sat Dec 31 07:22:11 2005
@@ -508,7 +508,7 @@
namespace = "http://www.w3.org/2000/xmlns/";
} else {
// Attribute name for this prefix's declaration
- String declname = (prefix == "") ? "xmlns" : "xmlns:" + prefix;
+ String declname = (prefix.equals("")) ? "xmlns" : "xmlns:" + prefix;
// Scan until we run out of Elements or have resolved the namespace
while ((null != parent) && (null == namespace)
Re: svn commit: r360290 - in /cocoon/trunk/src/java/org/apache/cocoon:
components/modules/output/SessionAttributeOutputModule.java xml/dom/DOMStreamer.java
Posted by Antonio Gallardo <ag...@agssa.net>.
Carsten Ziegeler wrote:
>antonio@apache.org schrieb:
>
>
>>Author: antonio
>>Date: Sat Dec 31 07:22:11 2005
>>New Revision: 360290
>>
>>URL: http://svn.apache.org/viewcvs?rev=360290&view=rev
>>Log:
>>Compares Strings using equals()
>>
>>Modified:
>> cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java
>> cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java
>>
>>
>>
>
>
>
>>- String declname = (prefix == "") ? "xmlns" : "xmlns:" + prefix;
>>+ String declname = (prefix.equals("")) ? "xmlns" : "xmlns:" + prefix;
>>
>>
>I think testing string length against zero is a better way.
>
>
OK. :-)
Best Regards,
Antonio Gallardo
Re: svn commit: r360290 - in /cocoon/trunk/src/java/org/apache/cocoon:
components/modules/output/SessionAttributeOutputModule.java xml/dom/DOMStreamer.java
Posted by Carsten Ziegeler <cz...@apache.org>.
antonio@apache.org schrieb:
> Author: antonio
> Date: Sat Dec 31 07:22:11 2005
> New Revision: 360290
>
> URL: http://svn.apache.org/viewcvs?rev=360290&view=rev
> Log:
> Compares Strings using equals()
>
> Modified:
> cocoon/trunk/src/java/org/apache/cocoon/components/modules/output/SessionAttributeOutputModule.java
> cocoon/trunk/src/java/org/apache/cocoon/xml/dom/DOMStreamer.java
>
> - String declname = (prefix == "") ? "xmlns" : "xmlns:" + prefix;
> + String declname = (prefix.equals("")) ? "xmlns" : "xmlns:" + prefix;
I think testing string length against zero is a better way.
Carsten
--
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/