You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/01/11 14:34:32 UTC

[GitHub] spark pull request #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable sup...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16549#discussion_r95588969
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -383,14 +383,25 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
             // Get all input data source relations of the query.
             val srcRelations = df.logicalPlan.collect {
               case LogicalRelation(src: BaseRelation, _, _) => src
    +          case relation: CatalogRelation if DDLUtils.isHiveTable(relation.catalogTable) => relation
             }
    +
             EliminateSubqueryAliases(catalog.lookupRelation(tableIdentWithDB)) match {
               // Only do the check if the table is a data source table (the relation is a BaseRelation).
    --- End diff --
    
    update this comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org