You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:03:47 UTC
[GitHub] [skywalking-rover] mrproliu opened a new pull request, #13: Add license and Let it could automatically generate
mrproliu opened a new pull request, #13:
URL: https://github.com/apache/skywalking-rover/pull/13
1. update the dependency licenses
2. integrate with [skywalking-eyes](https://github.com/apache/skywalking-eyes), let it could generate the license automatically.
3. Add to the CI, so it can check the dependency license in each PR.
@kezhenxu94 Please help to check the license generate code, there have some duplicated codes with eyes, not all of them. Maybe we could let the eyes generate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] mrproliu closed pull request #13: Add license and let it could automatically generate
Posted by GitBox <gi...@apache.org>.
mrproliu closed pull request #13: Add license and let it could automatically generate
URL: https://github.com/apache/skywalking-rover/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on pull request #13: Add license and let it could automatically generate
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #13:
URL: https://github.com/apache/skywalking-rover/pull/13#issuecomment-1098709606
@kezhenxu94 @mrproliu We may need to discuss whether is generating license reasonable, and what should be the policy.
Should we open a discussion separate in main repo about this before take any action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] mrproliu commented on pull request #13: Add license and let it could automatically generate
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #13:
URL: https://github.com/apache/skywalking-rover/pull/13#issuecomment-1098716561
> Should we open a discussion separate in main repo about this before take any action?
Sure. In my case, It could help me quickly generate the licenses file, and reduce the number of steps in the release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on pull request #13: Add license and let it could automatically generate
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #13:
URL: https://github.com/apache/skywalking-rover/pull/13#issuecomment-1120161066
Should we close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] mrproliu commented on pull request #13: Add license and let it could automatically generate
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #13:
URL: https://github.com/apache/skywalking-rover/pull/13#issuecomment-1120161283
Yes. closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org