You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/20 06:40:44 UTC
[jira] [Commented] (MNG-6173) MavenSession.getAllProjects() should
return all projects in the reactor
[ https://issues.apache.org/jira/browse/MNG-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874120#comment-15874120 ]
ASF GitHub Bot commented on MNG-6173:
-------------------------------------
GitHub user cboehme opened a pull request:
https://github.com/apache/maven/pull/105
MNG-6173 MavenSession.getAllProjects() should return all projects in the reactor
This commit moves the initialisation of the allProjects field in
MavenSession into the DefaultGraphBuilder as the full list of projects
in the reactor is only available their.
Since MavenSessions's projects and projectDependencyGraph fields were
already initialised in DefaultGraphBuilder, the code that sets them
again in DefaultMaven is removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cboehme/maven MNG-6173-get-all-projects
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 4085c3b568249ed06d78cb4657df462a095ee553
Author: Christoph Böhme <ch...@b3e.net>
Date: 2017-02-20T06:32:17Z
MNG-6173 MavenSession.getAllProjects() should return all projects in the reactor
This commit moves the initialisation of the allProjects field in
MavenSession into the DefaultGraphBuilder as the full list of projects
in the reactor is only available their.
Since MavenSessions's projects and projectDependencyGraph fields were
already initialised in DefaultGraphBuilder, the code that sets them
again in DefaultMaven is removed.
----
> MavenSession.getAllProjects() should return all projects in the reactor
> -----------------------------------------------------------------------
>
> Key: MNG-6173
> URL: https://issues.apache.org/jira/browse/MNG-6173
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.3.3, 3.3.9
> Reporter: Christoph Böhme
>
> According to MNG-5582 {{MavenSession.getAllProjects()}} should return all projects in the reactor even if the set is constrained by {{--projects}}. The current implementation, however, returns the same constrained list that is returned by {{MavenSession.getProjects()}}.
> This bug seems to have been introduced when MNG-5775 was implemented.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)