You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "astronaut-chris (via GitHub)" <gi...@apache.org> on 2023/03/02 12:58:53 UTC
[GitHub] [airflow] astronaut-chris opened a new issue, #29874: Filters don't persist after performing an action
astronaut-chris opened a new issue, #29874:
URL: https://github.com/apache/airflow/issues/29874
### Apache Airflow version
2.5.1
### What happened
When browsing DAG runs or task instances, the following workflow is common:
1. Filter for a specific set of dag runs, or a set of failed tasks
2. Tick all of the dags/tasks checkboxes
3. Hit Actions --> Set state to queued / Clear state
After performing an action, you are redirected to a fresh browsing page, without your previous filters enabled.
### What you think should happen instead
I would expect the filters I set to persist during the redirect.
(Though there are definitely some cases where this might not work as expected, e.g. I filter for failed tasks in a dag, I clear those tasks, and then on redirect, if my filter persisted, I would see nothing, because not of the tasks would be in a failed state anymore.)
### How to reproduce
1. Browse DAGs
2. Filter for a specific `dag_id`
3. Tick the selection box of one of the entries in the table
4. Hit Actions --> Set state to queued
5. Observe the redirect back to a clean browse page, without the previous `dag_id` filtered for.
### Operating System
Debian GNU/Linux 11 (bullseye
### Versions of Apache Airflow Providers
Not applicable
### Deployment
Astronomer
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #29874: Filters don't persist after performing an action
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #29874:
URL: https://github.com/apache/airflow/issues/29874#issuecomment-1452213089
Gladly. Sure, i will take a look during my morning time tomorrow 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Filters don't persist after performing an action [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #29874:
URL: https://github.com/apache/airflow/issues/29874#issuecomment-1893066427
Suddenly stumbled on this old issue and was able to reproduce it.
Trying to fix it, but I do not really understand where the code for this exactly is, I was looking in views.py but nothing concrete.
@bbovenzi if you have some time, could you roughly point me to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #29874: Filters don't persist after performing an action
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29874:
URL: https://github.com/apache/airflow/issues/29874#issuecomment-1452036555
@amoghrajesh would you like to take a look on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org