You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2021/01/14 19:56:00 UTC
[jira] [Commented] (IGNITE-13949) Insufficient synchronisation in
PartitionUpdateCounterTrackingImpl
[ https://issues.apache.org/jira/browse/IGNITE-13949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265176#comment-17265176 ]
Ignite TC Bot commented on IGNITE-13949:
----------------------------------------
{panel:title=Branch: [pull/8665/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8665/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5827697&buildTypeId=IgniteTests24Java8_RunAll]
> Insufficient synchronisation in PartitionUpdateCounterTrackingImpl
> ------------------------------------------------------------------
>
> Key: IGNITE-13949
> URL: https://issues.apache.org/jira/browse/IGNITE-13949
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.9.1
> Reporter: Yaroslav Molochkov
> Assignee: Yaroslav Molochkov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now org.apache.ignite.internal.processors.cache.PartitionUpdateCounterTrackingImpl has 2 AtomicLong variables, cntr and reserveCntr, but there are some methods, that are unsynchronised, e.g. next:
> {code:java}
> @Override public long next() {
> long next = cntr.incrementAndGet();
> reserveCntr.set(next);
> return next;
> } {code}
> Even though both are AtomicLong, operation like "get then set" is a composite one and should be atomic in the context of an object that holds these variables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)