[GitHub] [kafka] dengziming commented on a diff in pull request #12217: MINOR: Enable kraft support in quota integration tests

[GitBox <gi...@apache.org>]

dengziming commented on code in PR #12217:
URL: https://github.com/apache/kafka/pull/12217#discussion_r883250496


##########
core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala:
##########
@@ -70,23 +71,24 @@ abstract class BaseQuotaTest extends IntegrationTestHarness {
   val defaultRequestQuota: Double = Long.MaxValue.toDouble
 
   val topic1 = "topic-1"
-  var leaderNode: KafkaServer = _
-  var followerNode: KafkaServer = _
+  var leaderNode: KafkaBroker = _
+  var followerNode: KafkaBroker = _
   var quotaTestClients: QuotaTestClients = _
 
   @BeforeEach
   override def setUp(testInfo: TestInfo): Unit = {
     super.setUp(testInfo)
 
     val numPartitions = 1
-    val leaders = createTopic(topic1, numPartitions, brokerCount)
-    leaderNode = if (leaders(0) == servers.head.config.brokerId) servers.head else servers(1)
-    followerNode = if (leaders(0) != servers.head.config.brokerId) servers.head else servers(1)
+    val leaders = createTopic(topic1, numPartitions, brokerCount, adminClientConfig = adminClientConfig)

Review Comment:
   This change is due to security reasons? I wonder why it will succeed in ZK mode, does this mean we will bypass security certification in zk mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org