You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sun-rui <gi...@git.apache.org> on 2016/03/22 11:05:12 UTC
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
GitHub user sun-rui opened a pull request:
https://github.com/apache/spark/pull/11884
[SPARK-14006][SPARKR] Fix SparkR lint-r test errors in branch-1.6.
## What changes were proposed in this pull request?
A backport of #11652 for branch 1.6. It fixes all newly captured SparkR lint-r errors after the lintr package is updated from github.
## How was this patch tested?
dev/lint-r
SparkR unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sun-rui/spark SPARK-14006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11884.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11884
----
commit 404d9827d7d33a915721b961d6ae940b27b35145
Author: Sun Rui <ru...@intel.com>
Date: 2016-03-13T21:30:44Z
[SPARK-14006][SPARKR] Fix SparkR lint-r test errors in branch-1.6.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199741603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53762/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199949033
Merged into branch-1.6. @sun-rui Could you close this PR manually? Let's discuss the issue with `install_github` on SPARK-14074.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui closed the pull request at:
https://github.com/apache/spark/pull/11884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-200116786
yes. let's continue the discussion in the new JIRA issue. close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by jimhester <gi...@git.apache.org>.
Github user jimhester commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199951402
You can always pin to a specific tag, sha1, PR# using `install_github()`, there is no need for a CRAN release to have a stable source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199741470
**[Test build #53762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53762/consoleFull)** for PR 11884 at commit [`404d982`](https://github.com/apache/spark/commit/404d9827d7d33a915721b961d6ae940b27b35145).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199945953
@sun-rui Shall we use a released version of lintr from CRAN? Using `install_github` makes our builds depend on a mutable source. If we need some new features from lintr, we should ask the author to make a release on CRAN first. cc: @jimhester @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199731234
**[Test build #53762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53762/consoleFull)** for PR 11884 at commit [`404d982`](https://github.com/apache/spark/commit/404d9827d7d33a915721b961d6ae940b27b35145).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199741600
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14006][SPARKR] Fix SparkR lint-r test e...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11884#issuecomment-199971835
Git tags are mutable and commits could be removed from Git repo. CRAN is certainly a more stable source. Similarly, we use maven central for Java libraries and avoid using third-party repos in our build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org