You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/05/15 13:15:53 UTC
[GitHub] [submarine] Kenchu123 opened a new pull request, #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
Kenchu123 opened a new pull request, #957:
URL: https://github.com/apache/submarine/pull/957
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Create submarine operator with [operator-sdk](https://sdk.operatorframework.io/).
This is only the setup for future development environments.
### What type of PR is it?
Feature
### Todos
* [x] - initailize submarine-cloud-v3 with operator-sdk
* [x] - change types to generate submarine crd
* [x] - add new development doc
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/browse/SUBMARINE-1271
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Follow the `submarine-cloud-v3/docs/developer-guide.md`
### Screenshots (if appropriate)
Running operator in-cluster
<img width="1487" alt="Screen Shot 2022-05-15 at 9 11 55 PM" src="https://user-images.githubusercontent.com/17617373/168474591-448fb53b-8cb4-465c-a436-9a4f49ee961c.png">
Running submarine
<img width="1488" alt="Screen Shot 2022-05-15 at 9 13 08 PM" src="https://user-images.githubusercontent.com/17617373/168474656-0b31841e-3d66-4ea6-b087-24f50d73bb53.png">
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? Yes
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
URL: https://github.com/apache/submarine/pull/957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] joshvictor1024 commented on pull request #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
Posted by GitBox <gi...@apache.org>.
joshvictor1024 commented on PR #957:
URL: https://github.com/apache/submarine/pull/957#issuecomment-1126953307
looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #957:
URL: https://github.com/apache/submarine/pull/957#issuecomment-1126944501
# [Codecov](https://codecov.io/gh/apache/submarine/pull/957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#957](https://codecov.io/gh/apache/submarine/pull/957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9f3be5) into [master](https://codecov.io/gh/apache/submarine/commit/2a994f11ca81d919599efac0d4a68fef87044058?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a994f1) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head f9f3be5 differs from pull request most recent head 0c1b9be. Consider uploading reports for the commit 0c1b9be to get more accurate results
```diff
@@ Coverage Diff @@
## master #957 +/- ##
=========================================
Coverage 26.65% 26.65%
Complexity 53 53
=========================================
Files 34 34
Lines 709 709
Branches 57 57
=========================================
Hits 189 189
Misses 498 498
Partials 22 22
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2a994f1...0c1b9be](https://codecov.io/gh/apache/submarine/pull/957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #957: SUBMARINE-1271. Submarine-cloud-v3 initialization
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on PR #957:
URL: https://github.com/apache/submarine/pull/957#issuecomment-1126939948
Please help review. @MortalHappiness @joshvictor1024.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org