You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2019/02/23 00:11:05 UTC
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12560
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
Several ASAN runs of test_decimal_min_max_filters failed due to
the filters not arriving in time. This was because the codegen
time for the fragments was high and hence the scan node took long
to complete. This change increases the wait time from 100000ms to
200000ms.
Testing:
Executed the test 1000 times on an ASAN build without any failures.
Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
---
M tests/query_test/test_runtime_filters.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/12560/1
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG@16
PS2, Line 16: Executed the test 1000 times on an ASAN build without any failures.
> Among the failed builds, the slowest was 2m36s on jenkins. On my local mach
wfm, just wanted to be sure we looked at that possibility
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:26:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py
File tests/query_test/test_runtime_filters.py:
http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py@27
PS1, Line 27: # slow_build_timeout is set to 200000 to avoid failures like IMPALA-8064 where the
> nit: do you think it makes sense to add the small comment for the reason be
Done
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 00:24:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
Several ASAN runs of test_decimal_min_max_filters failed due to
the filters not arriving in time. This was because the codegen
time for the fragments was high and hence the scan node took long
to complete. This change increases the wait time from 100000ms to
200000ms.
Testing:
Executed the test 1000 times on an ASAN build without any failures.
Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
---
M tests/query_test/test_runtime_filters.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/12560/2
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2219/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 00:53:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG@16
PS2, Line 16: Executed the test 1000 times on an ASAN build without any failures.
codegen time can change under load, so running just this test might have a different outcome. Would you mind running this under a regular e2e test run on ASAN build, just to make sure we have enough room in the 200 sec timeout to accommodate any variance
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:11:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12560/2//COMMIT_MSG@16
PS2, Line 16: Executed the test 1000 times on an ASAN build without any failures.
> codegen time can change under load, so running just this test might have a
Among the failed builds, the slowest was 2m36s on jenkins. On my local machine, it was a maximum of 1m40s under load. I was thinking 3m20s should give it enough room. Or do you think I should increase it further?
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:22:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:26:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3822/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:26:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 05:32:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py
File tests/query_test/test_runtime_filters.py:
http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py@27
PS1, Line 27: WAIT_TIME_MS = build_flavor_timeout(60000, slow_build_timeout=200000)
nit: do you think it makes sense to add the small comment for the reason behind this value, just so that its not lost between future changes to this test.
Maybe just mention the jira id and not the whole reason.
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 00:20:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
Several ASAN runs of test_decimal_min_max_filters failed due to
the filters not arriving in time. This was because the codegen
time for the fragments was high and hence the scan node took long
to complete. This change increases the wait time from 100000ms to
200000ms.
Testing:
Executed the test 1000 times on an ASAN build without any failures.
Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Reviewed-on: http://gerrit.cloudera.org:8080/12560
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_runtime_filters.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2220/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e
Gerrit-Change-Number: 12560
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:05:37 +0000
Gerrit-HasComments: No