Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4

[Niklas Nielsen <ni...@qni.dk>]

> On Aug. 27, 2015, 1:27 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37823]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37823
> > 
> > Error:
> >  2015-08-27 20:25:09 URL:https://reviews.apache.org/r/37823/diff/raw/ [9017/9017] -> "37823.patch" [1]
> > error: missing binary patch data for '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> > error: binary patch does not apply to '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> > error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
> > Failed to apply patch

Hi Neil, maybe you need to make an explicit diff with --binary


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/#review96747
-----------------------------------------------------------


On Aug. 27, 2015, 1:11 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37824/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 1:11 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3322
>     https://issues.apache.org/jira/browse/MESOS-3322
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See MESOS-3322.
> 
> 
> Diffs
> -----
> 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/37824/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>