You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Maxim Logvinenko <ml...@gmail.com> on 2016/09/05 17:15:42 UTC

Review Request 51634: SAMZA-1014: Add property to set YARN AM cpu cores

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51634/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-1014
    https://issues.apache.org/jira/browse/SAMZA-1014


Repository: samza


Description
-------

In some cases we need to set up CPU cores count for samza application masters. Previously, samza had hardcoded value = 1 for CPU? cores. In this patch "yarn.am.container.cpu.cores" property has been added with default value 1.

This can be useful if we want to run AM on some specific nodes with specific CPU cores count.


Diffs
-----

  samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java 8f2dc48 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 0998c43 

Diff: https://reviews.apache.org/r/51634/diff/


Testing
-------


Thanks,

Maxim Logvinenko


Re: Review Request 51634: SAMZA-1014: Add property to set YARN AM cpu cores

Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51634/#review153467
-----------------------------------------------------------


Ship it!




Ship It!

- Jagadish Venkatraman


On Sept. 5, 2016, 5:15 p.m., Maxim Logvinenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51634/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2016, 5:15 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-1014
>     https://issues.apache.org/jira/browse/SAMZA-1014
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> In some cases we need to set up CPU cores count for samza application masters. Previously, samza had hardcoded value = 1 for CPU? cores. In this patch "yarn.am.container.cpu.cores" property has been added with default value 1.
> 
> This can be useful if we want to run AM on some specific nodes with specific CPU cores count.
> 
> 
> Diffs
> -----
> 
>   samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java 8f2dc48 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 0998c43 
> 
> Diff: https://reviews.apache.org/r/51634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Logvinenko
> 
>