You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/02/25 19:00:54 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2899:
[GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
autumnust opened a new pull request #2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1060
### Description
The existence checking of files to be localized in yarn appmaster / container need to happen against local fs object. Currently it is using HDFS fs object which is incorrect.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2899:
[GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899#issuecomment-591042125
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=h1) Report
> Merging [#2899](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2899 +/- ##
===========================================
- Coverage 4.12% 4.12% -0.01%
Complexity 750 750
===========================================
Files 1932 1932
Lines 72789 72792 +3
Branches 8022 8022
===========================================
Hits 3002 3002
- Misses 69469 69472 +3
Partials 318 318
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=footer). Last update [0de109b...0abc430](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899#discussion_r384128391
##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -608,21 +608,22 @@ private Resource prepareContainerResource(GetNewApplicationResponse newApplicati
Path appMasterWorkDir = new Path(appWorkDir, GobblinYarnConfigurationKeys.APP_MASTER_WORK_DIR_NAME);
Map<String, LocalResource> appMasterResources = Maps.newHashMap();
+ FileSystem localFs = FileSystem.getLocal(this.yarnConfiguration);
Review comment:
Maybe it is safer to use FileSystem.getLocal(new Configuration()) since we are dependent of fs.defaultFS not being configured in yarnConfiguration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2899:
[GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899#issuecomment-591042125
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=h1) Report
> Merging [#2899](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2899 +/- ##
============================================
- Coverage 45.86% 45.85% -0.01%
+ Complexity 9170 9167 -3
============================================
Files 1932 1932
Lines 72789 72792 +3
Branches 8022 8022
============================================
- Hits 33386 33382 -4
- Misses 36342 36352 +10
+ Partials 3061 3058 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.02% <0%> (-0.16%)` | `8 <0> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.26% <0%> (-3.48%)` | `14% <0%> (-1%)` | |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
| [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `15.32% <0%> (-0.84%)` | `4% <0%> (-1%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2899/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=footer). Last update [0de109b...5c71800](https://codecov.io/gh/apache/incubator-gobblin/pull/2899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2899:
[GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2899: [GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services