You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/09/06 15:45:38 UTC
svn commit: r1759448 - in /jmeter/trunk:
src/core/org/apache/jmeter/report/core/
src/core/org/apache/jmeter/report/processor/
src/core/org/apache/jmeter/report/processor/graph/impl/ xdocs/
Author: pmouawad
Date: Tue Sep 6 15:45:38 2016
New Revision: 1759448
URL: http://svn.apache.org/viewvc?rev=1759448&view=rev
Log:
Bug 60089 Report / Dashboard : Bytes throughput Over Time has reversed Sent and Received bytes
Contributed by Ubik Load Pack (support at ubikloadpack.com)
Bugzilla Id: 60089
Modified:
jmeter/trunk/src/core/org/apache/jmeter/report/core/Sample.java
jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/impl/BytesThroughputGraphConsumer.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/Sample.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/Sample.java?rev=1759448&r1=1759447&r2=1759448&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/Sample.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/Sample.java Tue Sep 6 15:45:38 2016
@@ -254,12 +254,22 @@ public class Sample {
}
/**
+ * Gets the number of received bytes stored in the sample.
+ *
+ * @return the number of received bytes stored in the sample
+ */
+ public int getReceivedBytes() {
+ return getData(int.class, CSVSaveService.CSV_BYTES).intValue();
+ }
+
+ /**
* Gets the number of sent bytes stored in the sample.
*
* @return the number of sent bytes stored in the sample
*/
public int getSentBytes() {
- return getData(int.class, CSVSaveService.CSV_BYTES).intValue();
+ // TODO To implement when metric is available
+ return 0;
}
/**
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java?rev=1759448&r1=1759447&r2=1759448&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java Tue Sep 6 15:45:38 2016
@@ -48,6 +48,7 @@ public class StatisticsSummaryConsumer e
void aggregateSample(Sample sample, StatisticsSummaryData data) {
data.incTotal();
+ data.incBytes(sample.getReceivedBytes());
data.incBytes(sample.getSentBytes());
if (!sample.getSuccess()) {
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/impl/BytesThroughputGraphConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/impl/BytesThroughputGraphConsumer.java?rev=1759448&r1=1759447&r2=1759448&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/impl/BytesThroughputGraphConsumer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/impl/BytesThroughputGraphConsumer.java Tue Sep 6 15:45:38 2016
@@ -78,9 +78,8 @@ public class BytesThroughputGraphConsume
@Override
public double select(String series, Sample sample) {
- // TODO Add Received bytes support
- return (SENT_BYTES_SERIES_LABEL.equals(series)) ? sample
- .getSentBytes() : 0;
+ return (RECEIVED_BYTES_SERIES_LABEL.equals(series)) ? sample
+ .getReceivedBytes() : sample.getSentBytes();
}
}, false, false));
return groupInfos;
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1759448&r1=1759447&r2=1759448&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Tue Sep 6 15:45:38 2016
@@ -204,6 +204,7 @@ Summary
<li><bug>59889</bug>Change encoding to UTF-8 in reports for dashboard.</li>
<li><bug>60053</bug>In Non GUI mode, a Stacktrace is shown at end of test while report is being generated</li>
<li><bug>60049</bug>When using Timers with high delays or Constant Throughput Timer with low throughput, Scheduler may take a lot of time to exit, same for Shutdown test </li>
+ <li><bug>60089</bug>Report / Dashboard : Bytes throughput Over Time has reversed Sent and Received bytes. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
</ul>
<!-- =================== Thanks =================== -->