You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/24 05:10:58 UTC
[GitHub] [apisix] ronething opened a new pull request, #8567: feat: consumer-restriction plugin support consumer_group_id type
ronething opened a new pull request, #8567:
URL: https://github.com/apache/apisix/pull/8567
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #8563
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8567: feat: consumer-restriction plugin support consumer_group_id type
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #8567:
URL: https://github.com/apache/apisix/pull/8567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ronething commented on a diff in pull request #8567: feat: consumer-restriction plugin support consumer_group_id type
Posted by GitBox <gi...@apache.org>.
ronething commented on code in PR #8567:
URL: https://github.com/apache/apisix/pull/8567#discussion_r1057086124
##########
t/plugin/consumer-restriction.t:
##########
@@ -1436,3 +1436,254 @@ passed
GET /t
--- response_body
passed
+
+
+
+=== TEST 54: create consumer group(group1)
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8567: feat: consumer-restriction plugin support consumer_group_id type
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8567:
URL: https://github.com/apache/apisix/pull/8567#discussion_r1057084335
##########
t/plugin/consumer-restriction.t:
##########
@@ -1436,3 +1436,254 @@ passed
GET /t
--- response_body
passed
+
+
+
+=== TEST 54: create consumer group(group1)
Review Comment:
Could you move the new tests to a new file?
> When the test file is too large, for example > 800 lines, you should split it to a new file. Please take a look at t/plugin/limit-conn.t and t/plugin/limit-conn2.t.
https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#check-code-style-and-test-case-style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org