You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/11 15:40:44 UTC

[GitHub] [cassandra] Gerrrr opened a new pull request #623: CASSANDRA-10968 2.1

Gerrrr opened a new pull request #623:
URL: https://github.com/apache/cassandra/pull/623


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] Gerrrr closed pull request #623: CASSANDRA-10968 2.1

Posted by GitBox <gi...@apache.org>.
Gerrrr closed pull request #623:
URL: https://github.com/apache/cassandra/pull/623


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] adelapena commented on a change in pull request #623: CASSANDRA-10968 2.1

Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #623:
URL: https://github.com/apache/cassandra/pull/623#discussion_r450163624



##########
File path: test/unit/org/apache/cassandra/db/ColumnFamilyStoreTest.java
##########
@@ -2233,4 +2237,34 @@ public void testRebuildSecondaryIndex() throws IOException
         
         PerRowSecondaryIndexTest.TestIndex.reset();
     }
+
+    @Test
+    public void testSnapshotWithoutFlushWithSecondaryIndexes() throws Exception
+    {
+        String keyspaceName = "Keyspace1";
+        String cfName= "Indexed1";

Review comment:
       Super nit, missed space char:
   ```suggestion
           String cfName = "Indexed1";
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org