You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/09/04 08:00:41 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

GitHub user bzz opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/280

    ZEPPELIN-76 skip Selenium tests on package

    Selenium-based tests are now triggerd by scalatest, instead of maven-failsafe-plugin, that is why they were triggered on `mvn package`.
    
    This PR moves scalatest invocation further down the chain, i.e now only `mvn verify` or `mvn install` will trigger them.
    
    No more `-DskipTests` by default!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bzz/incubator-zeppelin ZEPPELIN-76-add-skip-selenium-tests-on-package

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit a31b3d901d6455462548a1c061f1f6f9bbe1ff62
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2015-09-04T04:03:00Z

    ZEPPELIN-76: style fixes in Server, typo+format

commit 3b8d65a00c8e02a73237fdcce33c75952b58b5c7
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2015-09-04T05:57:15Z

    ZEPPELIN-76: moving Selenium-based IT to integration-test phase (mvn verify)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/280#issuecomment-137667231
  
    Ready to merge. #81 can be merged right after


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/280


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-76 skip Selenium tests o...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/280#issuecomment-137768184
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---