You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/08/21 20:08:32 UTC
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14119
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
69 files changed, 15,429 insertions(+), 37,419 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/1
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4876/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 31 Aug 2019 17:52:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl@52
PS3, Line 52: <li class="navbar-item"><a class="nav-link" href="{{link}}">{{title}}</a></li>
> The current font-size is larger than before that the nav bar become two lin
I explicitly set the body font size to 14px, that should get it closer to before.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl@33
PS3, Line 33: {{?stmt}}<pre>{{stmt}}</pre>{{/stmt}}
> We lost the syntax highlight without this. Why do we remove it? Is it incom
Ah right. The padding was a weird colour. I didn't think about syntax highlighting. I added the <code> tags back in. I think we can live with the padding.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl
File www/threadz_tabs.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl@22
PS3, Line 22: <ul class="nav nav-tabs">
> Tabs here are not displayed as usual. Need changes too.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 00:56:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#4).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz_tabs.tmpl
70 files changed, 15,446 insertions(+), 37,422 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/4
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl@166
PS4, Line 166: panel
> Now the /catalog page looks like missing styles. I found that all "panel" s
Followed the migration guide. The appearance is still a little different but closer now.
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@42
PS4, Line 42:
> nit: Looks like we use white spaces instead of tabs in other places.
oops, fixed
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@54
PS4, Line 54: <header class="navbar navbar-default navbar-expand bg-light navbar-static-top" id="top" role="banner">
> We used to have a 20px margin-bottom in the navbar. It'd be better to find
I don't mind the denser layout personally, would prefer to avoid adding customisation if it's not necessary.
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@68
PS4, Line 68: style='width:80%'
> Add 'max-width:3000px' or give it a larger value in the style. The boxes lo
Switching to container-fluid got a similar width back to before.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 04:01:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#2).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
69 files changed, 15,429 insertions(+), 37,419 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/2
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4327/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 23:39:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 4:
(4 comments)
I compare the web pages with the current version and still find somethings worth to fix. May need to go through https://getbootstrap.com/docs/4.1/migration/ for things we use.
http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl@166
PS4, Line 166: panel
Now the /catalog page looks like missing styles. I found that all "panel" stuffs should be changed to "card" according to https://getbootstrap.com/docs/4.1/migration/#panels
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@42
PS4, Line 42:
nit: Looks like we use white spaces instead of tabs in other places.
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@54
PS4, Line 54: <header class="navbar navbar-default navbar-expand bg-light navbar-static-top" id="top" role="banner">
We used to have a 20px margin-bottom in the navbar. It'd be better to find a way to implement it in Bootstrap 4. Maybe explicitly set it in style?
http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@68
PS4, Line 68: style='width:80%'
Add 'max-width:3000px' or give it a larger value in the style. The boxes look narrow in my browser.
It looks like we need to set this explicitly in Bootstrap 4: https://getbootstrap.com/docs/4.1/migration/#grid-system
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 03:32:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 4:
Do you have a chance to do another pass?
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2019 01:16:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 4:
Sure. Will look into this tomorrow.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2019 15:14:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 6: Code-Review+1
(4 comments)
LGTM. Just have some nits comments. I can give a +2 if Thomas don't have time to look into this.
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@26
PS6, Line 26: h2
The first three card titles look super huge now. Could we change it to h4?
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@72
PS6, Line 72: h2
Same here.
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@116
PS6, Line 116: h2
Same here
http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl
File www/threadz.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl@29
PS6, Line 29: h3
nit: Can we change these 'h3' to 'h4'? Now they look much larger than before.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 05:55:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4438/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 04:42:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#6).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz_tabs.tmpl
70 files changed, 15,464 insertions(+), 37,440 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/6
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#3).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
69 files changed, 15,430 insertions(+), 37,420 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/3
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#5).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz_tabs.tmpl
70 files changed, 15,464 insertions(+), 37,440 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/5
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#7).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz.tmpl
M www/threadz_tabs.tmpl
71 files changed, 15,471 insertions(+), 37,447 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/7
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 7: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 17:45:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Reviewed-on: http://gerrit.cloudera.org:8080/14119
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz.tmpl
M www/threadz_tabs.tmpl
71 files changed, 15,471 insertions(+), 37,447 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, but someone else must approve
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 31 Aug 2019 21:58:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4324/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 20:49:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 3:
(3 comments)
Add some comments at first glance and play around. Beside those, the table in the session page is too wide than before. It'd be better to fix it too.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl@52
PS3, Line 52: <li class="navbar-item"><a class="nav-link" href="{{link}}">{{title}}</a></li>
The current font-size is larger than before that the nav bar become two lines. In my browser, it's 1rem now. Previously, it's 14px. Maybe we need to explicitly set it.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl@33
PS3, Line 33: {{?stmt}}<pre>{{stmt}}</pre>{{/stmt}}
We lost the syntax highlight without this. Why do we remove it? Is it incompatible with bootstrap 4?
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl
File www/threadz_tabs.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl@22
PS3, Line 22: <ul class="nav nav-tabs">
Tabs here are not displayed as usual. Need changes too.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 00:18:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 6:
(4 comments)
I'm ok if you want to +2 without waiting for thomas, just depends if you want more eyes on it.
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@26
PS6, Line 26: h2
> The first three card titles look super huge now. Could we change it to h4?
Done
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@72
PS6, Line 72: h2
> Same here.
Done
http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@116
PS6, Line 116: h2
> Same here
Done
http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl
File www/threadz.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl@29
PS6, Line 29: h3
> nit: Can we change these 'h3' to 'h4'? Now they look much larger than befor
Done
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 17:45:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4440/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 18:25:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 23:35:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 01:37:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4437/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 04:32:11 +0000
Gerrit-HasComments: No