You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Chamila Wijayarathna <cd...@gmail.com> on 2014/08/04 07:47:10 UTC
'make cross' in travis
Hello all,
Currently in .travis.yml, even though we have 'make cross' running there,
it seems like it shows failure only when 'make cross' script fails to run,
but not when cross tests fails.
Eg -: https://travis-ci.org/cdwijayarathna/thrift/jobs/31338573 - Some coss
tests has failed, but 'make cross' exit with 0.
I think this is the same with 'make check' also.
So is this intended or, do we need to show failure at travis when cross
tests fails.
Thank You!
--
*Chamila Dilshan Wijayarathna,*
SMIEEE, SMIESL,
Undergraduate,
Department of Computer Science and Engineering,
University of Moratuwa.
Re: 'make cross' in travis
Posted by Roger Meier <ro...@bufferoverflow.ch>.
Hi Chamila
Quoting Chamila Wijayarathna <cd...@gmail.com>:
> Hi Roger,
>
> So we will fail execution of test.py if test with "exit":"hard" fails, am I
> correct?
yes
>
> With the current structure we have in tests.json, we can add "exit" feature
> to a client or server (eg: cpp client, py server, etc.), but not for a
> single test (eg- cpp_cpp_binary_buffered_ip,..) , some servers works well
> with some clients while fails with some. So how should I add that field?
please add it to the cpp clients first, these are the most robust and
should not fail.
afterwards we can add java, etc.
thanks
-roger
>
> Thank You!
>
>
> On Mon, Aug 4, 2014 at 1:09 PM, Roger Meier <ro...@bufferoverflow.ch> wrote:
>
>> Hi Chamila
>>
>> yes, make cross always exit with 0
>> otherwise it will always fail:-(
>>
>> Please add a new field to test/tests.json e.g.
>> "exit": "hard" => test suite fail
>> "exit": "soft" => test suite pass
>>
>> This will allow us to have *make cross* as part of regular test suite
>> and build will fail if e.g. cpp is broken because it is set to
>> "exit":"hard"
>>
>> Thanks
>> roger
>>
>>
>> Quoting Chamila Wijayarathna <cd...@gmail.com>:
>>
>> Hello all,
>>>
>>> Currently in .travis.yml, even though we have 'make cross' running there,
>>> it seems like it shows failure only when 'make cross' script fails to run,
>>> but not when cross tests fails.
>>>
>>> Eg -: https://travis-ci.org/cdwijayarathna/thrift/jobs/31338573 - Some
>>> coss
>>> tests has failed, but 'make cross' exit with 0.
>>>
>>> I think this is the same with 'make check' also.
>>>
>>> So is this intended or, do we need to show failure at travis when cross
>>> tests fails.
>>>
>>> Thank You!
>>>
>>> --
>>> *Chamila Dilshan Wijayarathna,*
>>>
>>> SMIEEE, SMIESL,
>>> Undergraduate,
>>> Department of Computer Science and Engineering,
>>> University of Moratuwa.
>>>
>>
>>
>
>
> --
> *Chamila Dilshan Wijayarathna,*
> SMIEEE, SMIESL,
> Undergraduate,
> Department of Computer Science and Engineering,
> University of Moratuwa.
Re: 'make cross' in travis
Posted by Chamila Wijayarathna <cd...@gmail.com>.
Hi Roger,
So we will fail execution of test.py if test with "exit":"hard" fails, am I
correct?
With the current structure we have in tests.json, we can add "exit" feature
to a client or server (eg: cpp client, py server, etc.), but not for a
single test (eg- cpp_cpp_binary_buffered_ip,..) , some servers works well
with some clients while fails with some. So how should I add that field?
Thank You!
On Mon, Aug 4, 2014 at 1:09 PM, Roger Meier <ro...@bufferoverflow.ch> wrote:
> Hi Chamila
>
> yes, make cross always exit with 0
> otherwise it will always fail:-(
>
> Please add a new field to test/tests.json e.g.
> "exit": "hard" => test suite fail
> "exit": "soft" => test suite pass
>
> This will allow us to have *make cross* as part of regular test suite
> and build will fail if e.g. cpp is broken because it is set to
> "exit":"hard"
>
> Thanks
> roger
>
>
> Quoting Chamila Wijayarathna <cd...@gmail.com>:
>
> Hello all,
>>
>> Currently in .travis.yml, even though we have 'make cross' running there,
>> it seems like it shows failure only when 'make cross' script fails to run,
>> but not when cross tests fails.
>>
>> Eg -: https://travis-ci.org/cdwijayarathna/thrift/jobs/31338573 - Some
>> coss
>> tests has failed, but 'make cross' exit with 0.
>>
>> I think this is the same with 'make check' also.
>>
>> So is this intended or, do we need to show failure at travis when cross
>> tests fails.
>>
>> Thank You!
>>
>> --
>> *Chamila Dilshan Wijayarathna,*
>>
>> SMIEEE, SMIESL,
>> Undergraduate,
>> Department of Computer Science and Engineering,
>> University of Moratuwa.
>>
>
>
--
*Chamila Dilshan Wijayarathna,*
SMIEEE, SMIESL,
Undergraduate,
Department of Computer Science and Engineering,
University of Moratuwa.
Re: 'make cross' in travis
Posted by Roger Meier <ro...@bufferoverflow.ch>.
Hi Chamila
yes, make cross always exit with 0
otherwise it will always fail:-(
Please add a new field to test/tests.json e.g.
"exit": "hard" => test suite fail
"exit": "soft" => test suite pass
This will allow us to have *make cross* as part of regular test suite
and build will fail if e.g. cpp is broken because it is set to "exit":"hard"
Thanks
roger
Quoting Chamila Wijayarathna <cd...@gmail.com>:
> Hello all,
>
> Currently in .travis.yml, even though we have 'make cross' running there,
> it seems like it shows failure only when 'make cross' script fails to run,
> but not when cross tests fails.
>
> Eg -: https://travis-ci.org/cdwijayarathna/thrift/jobs/31338573 - Some coss
> tests has failed, but 'make cross' exit with 0.
>
> I think this is the same with 'make check' also.
>
> So is this intended or, do we need to show failure at travis when cross
> tests fails.
>
> Thank You!
>
> --
> *Chamila Dilshan Wijayarathna,*
> SMIEEE, SMIESL,
> Undergraduate,
> Department of Computer Science and Engineering,
> University of Moratuwa.