You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/21 05:22:43 UTC
[GitHub] [flink] 1996fanrui opened a new pull request, #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
1996fanrui opened a new pull request, #21540:
URL: https://github.com/apache/flink/pull/21540
## What is the purpose of the change
Currently, the sort order is ascend by default, it should be descend.
The most busy subtask should be displayed on top.
## Brief change log
- Change the SortOrder of BusyRatio to descend by default.
- Don't change the order of `listOfSubTaskBackpressure`, it will sort by subtask when the user chooses not to sort.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1360875603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "60a63d238f64aff9a94dc4cda3a1f21f8845887a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60a63d238f64aff9a94dc4cda3a1f21f8845887a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 60a63d238f64aff9a94dc4cda3a1f21f8845887a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1361116851
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1362490165
> I think even before this PR, the sort order is also the desc by default. @yuchen-ecnu could you also take a look at this PR?
Thanks for your feedback, the `sortByBusyRatio` is `a - b`, so it's ascending order by default, and I have tested it's really ascending order. Please @yuchen-ecnu help double check, thanks~
```
sortByBusyRatio(a: JobBackpressureSubtask, b: JobBackpressureSubtask): number {
return a.busyRatio - b.busyRatio;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1367867001
Thanks @Myasuka and @yuchen-ecnu 's review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #21540:
URL: https://github.com/apache/flink/pull/21540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1360874693
After this PR:
1. The SortOrder of BusyRatio will be the desc by default.
<img width="981" alt="image" src="https://user-images.githubusercontent.com/38427477/208828005-d902a419-a197-4e55-be00-0b086cf89436.png">
2. It will sort by subtask when the user chooses not to sort.
<img width="1238" alt="image" src="https://user-images.githubusercontent.com/38427477/208828189-3702ece1-a77e-43b8-b08f-0974ec4097b7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1367777765
@yuchen-ecnu thanks for the review, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1362471115
I think even before this PR, the sort order is also the desc by default. @yuchen-ecnu could you also take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuchen-ecnu commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
yuchen-ecnu commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1363771038
Hi @Myasuka @Myasuka ,
The nzTable is sorted in descending order by default, you can refer to the following code. But specifying `nzSortOrder ` is a more standard usage. E.g., when `nzSortOrder ` is specified, the sorted icon in the head of the table is highlighted. Overall, this PR LGTM.
https://github.com/NG-ZORRO/ng-zorro-antd/blob/923f14eba1a4caa010d230c08a96ca0b344c65ea/components/table/src/table-data.service.ts#L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1360942141
Hi @Myasuka , please help take a look in your free time, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1363871116
Thanks for your feedback, I recorded a demo here, it explains the problem with the current master branch and why these two changes should be made.
Please correct me if I'm wrong, thanks~
https://user-images.githubusercontent.com/38427477/209327755-06f2807b-8c0b-41e2-9ea4-9fc4994c9f26.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org