You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/07/23 22:47:15 UTC
[jira] Issue Comment Edited: (LUCENE-1460) Change all contrib
TokenStreams/Filters to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734775#action_12734775 ]
Uwe Schindler edited comment on LUCENE-1460 at 7/23/09 1:45 PM:
----------------------------------------------------------------
bq. Question: instead of converting the tests to new api, would it be more beneficial to test both? testNewAPI() / testOldAPI()
No need to do this. The correct backwards-compatibility of the new API is checked separately by the extra test in LUCENE-1693.
It is enough if you remove all next() methods, add incrementToken() and make the above mentioned changes to make the token streams final where possible (see the comment of Michael Busch above -- which is the "howto" for the conversion).
The testy should only test the new API, but until they are also converted, the old tests should also still work (because of the backwards-compatibility layer). Be sure to apply LUCENE-1693 which does not change anything in contrib before starting to create a patch to have the newest API. Hopefully Michael has committed 1693 tomorrow.
LUCENE-1460_core.txt is already in LUCENE-1693 as it is part of core token streams.
was (Author: thetaphi):
bq. Question: instead of converting the tests to new api, would it be more beneficial to test both? testNewAPI() / testOldAPI()
No need to do this. The correct backwards-compatibility of tests is checked separately by the extra test in LUCENE-1693.
It is enough if you remove all next() methods, add incrementToken() and make the above mentioned changes to make the token streams final where possible (see the comment of Michael Busch above -- which is the "howto" for the conversion).
The testy should only test the new API, but until they are also converted, the old tests should also still work (because of the backwards-compatibility layer). Be sure to apply LUCENE-1693 which does not change anything in contrib before starting to create a patch to have the newest API. Hopefully Michael has committed 1693 tomorrow.
LUCENE-1460_core.txt is already in LUCENE-1693 as it is part of core token streams.
> Change all contrib TokenStreams/Filters to use the new TokenStream API
> ----------------------------------------------------------------------
>
> Key: LUCENE-1460
> URL: https://issues.apache.org/jira/browse/LUCENE-1460
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1460_contrib_partial.txt, LUCENE-1460_core.txt, LUCENE-1460_partial.txt
>
>
> Now that we have the new TokenStream API (LUCENE-1422) we should change all contrib modules to use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org