[GitHub] [helix] jiajunwang opened a new pull request #543: Change change detector to a regular field in the WAGED rebalaner instead of static threadlocal.

[GitBox <gi...@apache.org>]

jiajunwang opened a new pull request #543: Change change detector to a regular field in the WAGED rebalaner instead of static threadlocal.
URL: https://github.com/apache/helix/pull/543
 
 
   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   #540 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   The rebalance has been modified to be a thread-local object. So there is no need to keep the change detector as thread-local. This may cause a potential problem.
   In addition, in order to avoid resource leakage, implement the finalize method of the WagedRebalancer to close all connections.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   TestWagedRebalancer
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Copy & paste the result of "mvn test")
   
   ### Commits
   
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   NA
   
   ### Code Quality
   
   - [ ] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org