You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by smarthi <gi...@git.apache.org> on 2015/03/07 05:46:35 UTC
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-samoa/pull/15
SAMOA-7: Unnecessary distance method in SilhouetteCoefficient.java
Fixes SAMOA-7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-samoa suneel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 557e77842dfa886a517d847b24b045eafb31cea0
Author: Suneel Marthi <su...@gmail.com>
Date: 2015-03-07T04:45:50Z
SAMOA-7: Unnecessary distance method in SilhouetteCoefficient.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by arinto <gi...@git.apache.org>.
Github user arinto commented on the pull request:
https://github.com/apache/incubator-samoa/pull/15#issuecomment-77812788
Apart form the small comments above, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by arinto <gi...@git.apache.org>.
Github user arinto commented on a diff in the pull request:
https://github.com/apache/incubator-samoa/pull/15#discussion_r26019206
--- Diff: samoa-api/src/main/java/com/yahoo/labs/samoa/evaluation/measures/SilhouetteCoefficient.java ---
@@ -60,6 +60,7 @@ public void evaluateClustering(Clustering clustering, Clustering trueClustering,
for (int p = 0; p < points.size(); p++) {
DataPoint point = points.get(p);
ArrayList<Integer> ownClusters = new ArrayList<>();
+ double pointInclusionProbThreshold = 0.8;
--- End diff --
What if we use `private static final double` for this threshold?
So that the threshold is immutable and we don't need unnecessary declaration in line 63.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-samoa/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/15#issuecomment-87588709
@arinto's comments have been addressed, this PR has been in 'ready to merge' mode for a long time now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by gdfm <gi...@git.apache.org>.
Github user gdfm commented on the pull request:
https://github.com/apache/incubator-samoa/pull/15#issuecomment-87585632
Hi, @arinto's comments haven't been addressed yet, right?
I will wait an update on the PR to review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/15#issuecomment-77843798
@arinto +1 to your comment, updated the PR with the change. Thank u.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-7: Unnecessary distance method...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/15#issuecomment-89514939
@gdfm please merge this PR, its been pending merge since this project has moved to Apache Incubator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---