You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yangze Guo (Jira)" <ji...@apache.org> on 2021/10/15 07:50:00 UTC
[jira] [Commented] (FLINK-24562) YarnResourceManagerDriverTest
should not use ContainerStatusPBImpl.newInstance
[ https://issues.apache.org/jira/browse/FLINK-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429156#comment-17429156 ]
Yangze Guo commented on FLINK-24562:
------------------------------------
I think it is a valid issue. Would you like to prepare a PR for it?
If not, I'd like to fix that issue.
cc [~trohrmann]
> YarnResourceManagerDriverTest should not use ContainerStatusPBImpl.newInstance
> ------------------------------------------------------------------------------
>
> Key: FLINK-24562
> URL: https://issues.apache.org/jira/browse/FLINK-24562
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
> Affects Versions: 1.14.0
> Reporter: Feifan Wang
> Priority: Major
>
> In YarnResourceManagerDriverTest, we create ContainerStatus with the static method ContainerStatusPBImpl{{.newInstance}}, which is annotated as private and unstable.
> Although this method is still available in the latest version of yarn, some third-party versions of yarn may modify it. In fact, this method was modified in the internal version provided by our yarn team, which caused flink-1.14.0 to fail to compile.
> Moreover, there is already an org.apache.flink.yarn.TestingContainerStatus, I think we should use it directly.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)