You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/05/07 03:28:08 UTC
Review Request 33924: Adding missing API hook support in kill
commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1307
https://issues.apache.org/jira/browse/AURORA-1307
Repository: aurora
Description
-------
Added missing config options and refactored relevant tests.
Diffs
-----
src/main/python/apache/aurora/client/cli/context.py bd40410ccd0b02d0358e46eef015ce5d625c239f
src/main/python/apache/aurora/client/cli/jobs.py 6d82a7e7d97f7bf8621669ce76e24c9f4c1a371d
src/main/python/apache/aurora/client/cli/options.py d175e8cc061c305fe95ccfdc00f4b91cfa30ad96
src/test/python/apache/aurora/client/cli/test_cancel_update.py f9facb6dfd22b578359a68435d3e72318f5f158c
src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853
src/test/python/apache/aurora/client/cli/util.py 1fbf05009c298dfb854cec7b699e557eb1499a43
Diff: https://reviews.apache.org/r/33924/diff/
Testing
-------
./pants test.pytest --no-fast src/test/python:all
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
Re: Review Request 33924: Adding missing API hook support in kill
commands.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review83072
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On May 6, 2015, 6:28 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33924/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 6:28 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1307
> https://issues.apache.org/jira/browse/AURORA-1307
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added missing config options and refactored relevant tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py bd40410ccd0b02d0358e46eef015ce5d625c239f
> src/main/python/apache/aurora/client/cli/jobs.py 6d82a7e7d97f7bf8621669ce76e24c9f4c1a371d
> src/main/python/apache/aurora/client/cli/options.py d175e8cc061c305fe95ccfdc00f4b91cfa30ad96
> src/test/python/apache/aurora/client/cli/test_cancel_update.py f9facb6dfd22b578359a68435d3e72318f5f158c
> src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853
> src/test/python/apache/aurora/client/cli/util.py 1fbf05009c298dfb854cec7b699e557eb1499a43
>
> Diff: https://reviews.apache.org/r/33924/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
> Manual testing in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 33924: Adding missing API hook support in kill
commands.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review82901
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 7, 2015, 1:28 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33924/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 1:28 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1307
> https://issues.apache.org/jira/browse/AURORA-1307
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added missing config options and refactored relevant tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py bd40410ccd0b02d0358e46eef015ce5d625c239f
> src/main/python/apache/aurora/client/cli/jobs.py 6d82a7e7d97f7bf8621669ce76e24c9f4c1a371d
> src/main/python/apache/aurora/client/cli/options.py d175e8cc061c305fe95ccfdc00f4b91cfa30ad96
> src/test/python/apache/aurora/client/cli/test_cancel_update.py f9facb6dfd22b578359a68435d3e72318f5f158c
> src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853
> src/test/python/apache/aurora/client/cli/util.py 1fbf05009c298dfb854cec7b699e557eb1499a43
>
> Diff: https://reviews.apache.org/r/33924/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
> Manual testing in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 33924: Adding missing API hook support in kill
commands.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review82785
-----------------------------------------------------------
Ship it!
Master (fef7194) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 7, 2015, 1:28 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33924/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 1:28 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1307
> https://issues.apache.org/jira/browse/AURORA-1307
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added missing config options and refactored relevant tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py bd40410ccd0b02d0358e46eef015ce5d625c239f
> src/main/python/apache/aurora/client/cli/jobs.py 6d82a7e7d97f7bf8621669ce76e24c9f4c1a371d
> src/main/python/apache/aurora/client/cli/options.py d175e8cc061c305fe95ccfdc00f4b91cfa30ad96
> src/test/python/apache/aurora/client/cli/test_cancel_update.py f9facb6dfd22b578359a68435d3e72318f5f158c
> src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853
> src/test/python/apache/aurora/client/cli/util.py 1fbf05009c298dfb854cec7b699e557eb1499a43
>
> Diff: https://reviews.apache.org/r/33924/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
> Manual testing in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>