You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2022/01/07 11:03:51 UTC

[directory-ldap-api] branch master updated: Inject the byte[] extended request value into the instance in any case

This is an automated email from the ASF dual-hosted git repository.

elecharny pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/directory-ldap-api.git


The following commit(s) were added to refs/heads/master by this push:
     new 25cab63  Inject the byte[] extended request value into the instance in any case
25cab63 is described below

commit 25cab63df0e280fc93b3bbf140f05c90baca8fba
Author: emmanuel lecharny <el...@apache.org>
AuthorDate: Fri Jan 7 12:03:46 2022 +0100

    Inject the byte[] extended request value into the instance in any case
---
 .../request/extended/StoreExtendedRequestValue.java    | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/actions/request/extended/StoreExtendedRequestValue.java b/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/actions/request/extended/StoreExtendedRequestValue.java
index 67f445a..c182984 100644
--- a/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/actions/request/extended/StoreExtendedRequestValue.java
+++ b/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/actions/request/extended/StoreExtendedRequestValue.java
@@ -75,19 +75,17 @@ public class StoreExtendedRequestValue extends GrammarAction<LdapMessageContaine
         // value
         try
         {
-            if ( factory == null )
+            if ( tlv.getLength() == 0 )
             {
-                if ( tlv.getLength() == 0 )
-                {
-                    ( ( OpaqueExtendedRequest ) extendedRequest ).setRequestValue( Strings.EMPTY_BYTES );
-                } 
-                else
-                {
-                    ( ( OpaqueExtendedRequest ) extendedRequest ).setRequestValue( tlv.getValue().getData() );
-                }
-            }
+                ( ( OpaqueExtendedRequest ) extendedRequest ).setRequestValue( Strings.EMPTY_BYTES );
+            } 
             else
             {
+                ( ( OpaqueExtendedRequest ) extendedRequest ).setRequestValue( tlv.getValue().getData() );
+            }
+
+            if ( factory != null )
+            {
                 factory.decodeValue( extendedRequest, tlv.getValue().getData() );
             }
         }