You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/05/02 22:14:40 UTC
Review Request: SQOOP-480 MS SQL server connector is incompatible with
Sqoop-1.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------
Review request for Sqoop.
Summary
-------
Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration from com.cloudera to org.apache.
The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.
Diffs
-----
/build.xml 1333179
/src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179
/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179
Diff: https://reviews.apache.org/r/4972/diff
Testing
-------
1) Ran SQLServerManagerImportTest using the Microsoft connector.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.
Thanks,
Cheolsoo
Re: Review Request: SQOOP-480 MS SQL server connector is incompatible with
Sqoop-1.4
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------
(Updated 2012-05-27 20:02:25.273901)
Review request for Sqoop, Bilung Lee and Jarek Cecho.
Summary
-------
Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration from com.cloudera to org.apache.
The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.
This addresses bug SQOOP-480.
https://issues.apache.org/jira/browse/SQOOP-480
Diffs
-----
/build.xml 1333179
/src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179
/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179
Diff: https://reviews.apache.org/r/4972/diff
Testing
-------
1) Ran 'ant test -Dtestcase=SQLServerManagerImportManualTest' with both built-in SQL connector and Microsoft connector.
2) Ran 'ant test', 'ant test -Dthirdparty=true', and 'ant checkstyle'.
Thanks,
Cheolsoo
Re: Review Request: SQOOP-480 MS SQL server connector is incompatible with
Sqoop-1.4
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------
(Updated 2012-05-27 19:54:47.874627)
Review request for Sqoop.
Summary
-------
Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration from com.cloudera to org.apache.
The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.
This addresses bug SQOOP-480.
https://issues.apache.org/jira/browse/SQOOP-480
Diffs
-----
/build.xml 1333179
/src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179
/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179
Diff: https://reviews.apache.org/r/4972/diff
Testing (updated)
-------
1) Ran 'ant test -Dtestcase=SQLServerManagerImportManualTest' with both built-in SQL connector and Microsoft connector.
2) Ran 'ant test', 'ant test -Dthirdparty=true', and 'ant checkstyle'.
Thanks,
Cheolsoo
Re: Review Request: SQOOP-480 MS SQL server connector is incompatible with
Sqoop-1.4
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------
(Updated 2012-05-02 22:33:28.094041)
Review request for Sqoop.
Summary
-------
Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration from com.cloudera to org.apache.
The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.
This addresses bug SQOOP-480.
https://issues.apache.org/jira/browse/SQOOP-480
Diffs
-----
/build.xml 1333179
/src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179
/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179
Diff: https://reviews.apache.org/r/4972/diff
Testing
-------
1) Ran SQLServerManagerImportTest using the Microsoft connector.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.
Thanks,
Cheolsoo